Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13.3.0 release #1229

Merged
merged 5 commits into from
Feb 8, 2023
Merged

13.3.0 release #1229

merged 5 commits into from
Feb 8, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 7, 2023

🎈 Release

Preparation for 13.3.0 release.

Comparison to 13.2.0: sdformat13_13.2.0...prep_13.3.0

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits. LGTM otherwise.

Changelog.md Outdated
@@ -1,6 +1,27 @@
## libsdformat 13.X

### libsdformat 13.3.0 (2022-12-12)
### libsdformat 13.3.0 (2022-02-07)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2023

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. 941b2c3

Changelog.md Outdated
1. Make ThrowOrPrintError a free internal function
* [Pull request #1221](https://github.com/gazebosim/sdformat/pull/1221)

1. Make throwOrPrintErrors a member of sdf::Error
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: These two can be combined

Copy link
Contributor Author

@iche033 iche033 Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combined, and left the PR description to be Make ThrowOrPrintError a free internal function. 941b2c3

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1229 (19cd95e) into sdf13 (a893cd8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            sdf13    #1229   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         126      126           
  Lines       16301    16301           
=======================================
  Hits        14214    14214           
  Misses       2087     2087           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Changelog.md Outdated
* [Pull request #1118](https://github.com/gazebosim/sdformat/pull/1118)

1. Don't assume CMAKE_INSTALL_*DIR variables are relative
* [Pull request #1190](https://github.com/gazebosim/sdformat/pull/1190)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this one too because it only applied to sdf9 and couldn't be merged forward

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iche033 iche033 merged commit 08b6c15 into sdf13 Feb 8, 2023
@iche033 iche033 deleted the prep_13.3.0 branch February 8, 2023 00:39
mjcarroll pushed a commit that referenced this pull request Feb 9, 2023
Preparation for 13.3.0 release.

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants