-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13.3.0 release #1229
13.3.0 release #1229
Conversation
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits. LGTM otherwise.
Changelog.md
Outdated
@@ -1,6 +1,27 @@ | |||
## libsdformat 13.X | |||
|
|||
### libsdformat 13.3.0 (2022-12-12) | |||
### libsdformat 13.3.0 (2022-02-07) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. 941b2c3
Changelog.md
Outdated
1. Make ThrowOrPrintError a free internal function | ||
* [Pull request #1221](https://github.com/gazebosim/sdformat/pull/1221) | ||
|
||
1. Make throwOrPrintErrors a member of sdf::Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: These two can be combined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combined, and left the PR description to be Make ThrowOrPrintError a free internal function
. 941b2c3
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1229 +/- ##
=======================================
Coverage 87.19% 87.19%
=======================================
Files 126 126
Lines 16301 16301
=======================================
Hits 14214 14214
Misses 2087 2087 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ian Chen <[email protected]>
Changelog.md
Outdated
* [Pull request #1118](https://github.com/gazebosim/sdformat/pull/1118) | ||
|
||
1. Don't assume CMAKE_INSTALL_*DIR variables are relative | ||
* [Pull request #1190](https://github.com/gazebosim/sdformat/pull/1190) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this one too because it only applied to sdf9
and couldn't be merged forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Steve Peters <[email protected]>
Preparation for 13.3.0 release. Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Steve Peters <[email protected]>
🎈 Release
Preparation for 13.3.0 release.
Comparison to 13.2.0: sdformat13_13.2.0...prep_13.3.0
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.