Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make SDF to USD a separate component of sdformat #817
make SDF to USD a separate component of sdformat #817
Changes from 21 commits
5e13b49
fa4568b
18f3ac1
3bbd6ea
16e0789
ae3ee43
36d42fc
4545723
91629c0
6347953
bb6ee5a
d1d7af6
bab9e37
cbdfa49
99fb170
819d5f5
92eca63
0618353
bcc282b
0fd2568
0195564
d91557e
f3922f0
4c454a3
95c07e9
b29b737
c4c189f
0851949
01aeb57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI has a configuration warning still.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuration warnings should be gone now thanks to gazebo-tooling/release-tools#625, but I realize that until this PR is merged, gazebo-tooling/release-tools#625 will cause CI warnings on other sdformat PRs, as mentioned in gazebo-tooling/release-tools#625 (comment). I'm not sure if we should merge this PR first to take care of CI warnings on other PRs, or revert gazebo-tooling/release-tools#625 until it's time to merge this PR. Does anyone have thoughts on how to handle this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can merge this today? If so, I think it's fine, but if not, there are at least two PRs waiting to be merged blocked on the CI failure, so I would recommend reverting the release-tools change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this can be merged today if the fix I mentioned in #817 (comment) seems valid. The only lingering question I have is about if we want to structure include guards in a particular way for the SDF -> USD and USD -> SDF converters, which isn't really a blocker: #817 (comment)
If CI is green, everything else has been addressed, so I think we should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed the include guard fix, so I'm just waiting on CI to see if it comes back green 🤞