Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(general): Don't fail events containing a span with missing timestamp #1690

Merged
merged 15 commits into from
Dec 14, 2022
Merged

feat(general): Don't fail events containing a span with missing timestamp #1690

merged 15 commits into from
Dec 14, 2022

Conversation

TBS1996
Copy link
Contributor

@TBS1996 TBS1996 commented Dec 13, 2022 •
edited
Loading

If theres a missing timestamp on a span, it will get the timestamp of the event it belongs to, and it will get the status of DeadlineExceeded. Check issue for more info

Ref #1244

@TBS1996 TBS1996 requested a review from a team December 13, 2022 11:28
jjbayer
jjbayer reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just two minor comments.

relay-general/src/store/transactions.rs Show resolved Hide resolved
relay-general/src/store/transactions.rs Outdated Show resolved Hide resolved
@TBS1996 TBS1996 changed the title feat/fix span timestamp feat: don't fail spans that are missing their timestamp Dec 13, 2022
@TBS1996 TBS1996 changed the title feat: don't fail spans that are missing their timestamp feat(general): don't fail spans that are missing their timestamp Dec 13, 2022
@TBS1996 TBS1996 requested a review from jjbayer December 13, 2022 13:24
jjbayer
jjbayer approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog as discussed, apart from that, this looks good!

@jan-auer jan-auer changed the title feat(general): don't fail spans that are missing their timestamp feat(general): Don't fail spans that are missing their timestamp Dec 13, 2022
@TBS1996 TBS1996 changed the title feat(general): Don't fail spans that are missing their timestamp feat(general): Don't fail events containing a span with missing timestamp Dec 14, 2022
@TBS1996 TBS1996 merged commit efbdb32 into master Dec 14, 2022
@TBS1996 TBS1996 deleted the feat/fix-span-timestamp branch December 14, 2022 15:00
@kahest kahest mentioned this pull request May 31, 2023
Open
@philipphofmann philipphofmann mentioned this pull request May 31, 2023
Open
@stefanosiano stefanosiano mentioned this pull request May 31, 2023
Closed
@denrase denrase mentioned this pull request Aug 14, 2023
Merged
6 tasks
@bruno-garcia bruno-garcia mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olksdr olksdr olksdr left review comments

@jjbayer jjbayer jjbayer approved these changes

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TBS1996 @jan-auer @jjbayer @olksdr