Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refrain from overwriting the span status for unfinished spans #2730

Closed
Tracked by #128
markushi opened this issue May 24, 2023 · 2 comments
Closed
Tracked by #128

Refrain from overwriting the span status for unfinished spans #2730

markushi opened this issue May 24, 2023 · 2 comments
Assignees
@markushi
Labels
Platform: Android Platform: Java
Milestone
7.0.0

Comments

@markushi
Copy link
Member

markushi commented May 24, 2023 •
edited
Loading

Problem Statement

As discussed in #1690 unfinished spans should be sent, but their status should not be set to deadline_exceeded.

Solution Brainstorm

Don't overwrite the span status.
@markushi markushi changed the title Refrain from overwriting the span status for unfinished spans. Refrain from overwriting the span status for unfinished spans May 24, 2023
This was referenced May 24, 2023
Closed
Open
@markushi markushi added this to the 7.0.0 milestone May 25, 2023
@markushi
Copy link
Member Author

Let's keep self-hosted in mind here, and add corresponding information to the release.

@stefanosiano
Copy link
Member

the corresponding pr in relay was in Dec 2022

@markushi markushi self-assigned this Jul 20, 2023
@markushi markushi mentioned this issue Jul 20, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markushi markushi

Labels
Platform: Android Platform: Java
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
7.0.0
Development

No branches or pull requests
3 participants
@markushi @kahest @stefanosiano