Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refrain from overwriting the span status for unfinished spans #128

Open
3 of 6 tasks
markushi opened this issue May 25, 2023 · 1 comment
Open
3 of 6 tasks

Refrain from overwriting the span status for unfinished spans #128

markushi opened this issue May 25, 2023 · 1 comment

Comments

@markushi
Copy link
Member

markushi commented May 25, 2023

Problem Statement

As discussed in getsentry/sentry-java#1690 unfinished spans should be sent, but their status should not be set to deadline_exceeded.

Tasks

  1. Platform: Android Platform: Java
    markushi
  2. Breaking-change Platform: Cocoa
  3. Platform: React-Native
  4. Breaking-change Platform: Dart performance
    denrase
  5. Feature Platform: .NET Product: Tracing
    bitsandfoxes jamescrosswell

From the Relay Issue:

Relay will no longer drop transactions that contain Spans without end timestamp
In this approach, the SDKs can remove the logic of handling unfinished spans. Relay now will be free to take the best approach to the problem:

Relay will add the transaction’s timestamp to the Span and the status deadline_exceeded, to indicate this span didn't complete during the transaction.

Relevant Relay PR: getsentry/relay#1690
Note: for older self-hosted installations this can break transactions

Solution Brainstorm

Don't overwrite the span status.

@markushi
Copy link
Member Author

markushi commented Jul 21, 2023

After taking a closer look at the relay changes leaving the status untouched is not enough, we also need to set no end time on the span.
Relay will only set the status to deadline_exceeded if no end time is provided. Along the way it will also set an end time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Discussion
Development

No branches or pull requests

3 participants