Include unfinished spans in transactions

[bruno-garcia]

When a transaction is finished, the SDK tries to send the data to Sentry.
If an open Span (one that was not finished) exist in that transaction, the SDK removes that span before sending the data to Sentry.

That was done because Sentry will discard the transaction if unfinished spans are included. More context on this thread: getsentry/develop#274

An alternative solution used by the JavaScript SDK is to complete those spans with the timestamp of the finishing transaction and setting the status to timeline_exceeded. We should align with this approach as it shows something was going on even though it wasn't completed during the transaction.

On:

Tasks

Beta Give feedback

We're having trouble rendering your tasklist, it's most likely has one of the following formatting errors:

• indented tasks (i.e. nested tasklist; support for this is coming!)
• an empty task (i.e. - [ ] on a line by itself)
• any empty new lines (before/after the tasklist or in between tasks)
• duplicate issue/pr links
• a draft task exceeds 512 characters

Please check the tasklists documentation for more information. 🔗 Feedback Discussion

Thank you for participating in the Private Beta ❤️

1. Include unfinished spans in transactions sentry-cocoa#1303
   +0
2. Include unfinished spans in transactions sentry-dotnet#1182
   Feature Platform: .NET Product: Tracing +3
   
3. Accept transactions containing unfinished spans relay#1244
   Status: Backlog +1
   

[marandaneto]

deadline_exceeded the status is called

[bruno-garcia]

Reopening as the goal is to stop modifying the span status (or removing it for that matter) if a span is not finished.
Relay will take care of it: getsentry/relay#1244
Related .NET issue: getsentry/sentry-dotnet#1182

Worth noting once we revert the change here we'll need to notify the minimum Self Hosted version required since the old version of Relay dropped transactions completely if they had an unfinished span (reason why all SDKs compensated that with dropping or lying about a span being finished)

[markushi]

Let's remove the hack of setting the deadline_exceeded status and just send the span as-is. Given that this is a breaking change (at least for self-hosted) let's implement this with the next milestone.

[markushi]

Closing this one in favor of the follow up meta ticket getsentry/team-mobile#128