Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+K to comment lines in shader editor isn't working if the shader is a .gdshaderinc #78205

Closed
Zylann opened this issue Jun 13, 2023 · 0 comments · Fixed by #79158
Closed

Ctrl+K to comment lines in shader editor isn't working if the shader is a .gdshaderinc #78205

Zylann opened this issue Jun 13, 2023 · 0 comments · Fixed by #79158
Labels
bug topic:editor topic:shaders usability
Milestone
4.2

Comments

@Zylann
Copy link
Contributor

Zylann commented Jun 13, 2023 •
edited
Loading

Godot version

Godot 4.0.3

System information

Windows 10 64 bits NVIDIA GeForce GTX 1060

Issue description

Ctrl+K is a shortcut normally used to comment out the current line. It works in the shader editor, but for some reason, it doesn't if your shader has the .gdshaderinc extension (aka it's a shader include). Shader Includes are the same language, we should be able to use that feature.

Steps to reproduce

Create a .gdshaderinc file. Write some code in it. Observe you can't use Ctrl+K to comment out lines.

Minimal reproduction project

CommentLinesShaderInc.zip
@clayjohn clayjohn added this to the 4.x milestone Jun 13, 2023
@jpcerrone jpcerrone mentioned this issue Jul 7, 2023
Merged
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Jul 8, 2023
YuriSizov pushed a commit to YuriSizov/godot that referenced this issue Jul 10, 2023
@jpcerrone @YuriSizov
Fix comments and indentation in .gdshaderinc files
2ba192e 
Fixes godotengine#78205
The handling of comments and indentation in the shader editor
wasn't considering shader include files.

(cherry picked from commit 71b8a9d)
@TokisanGames TokisanGames mentioned this issue Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor topic:shaders usability
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Fix comments and indentation in .gdshaderinc files jpcerrone/godot
3 participants
@Zylann @akien-mga @clayjohn