Recurse into resources to check for changed node paths #80721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Oct 1, 2023
KoBeWi
approved these changes
Oct 1, 2023
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
tom95
force-pushed
the
resource-node-path-renaming
branch
from
1401307
to
42a3108
Compare
|
Thanks for the note @akien-mga, I had forgotten. All done now :) |
|
Thanks! |
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74155 by recursing into resources when checking for changed
NodePaths. Also verified to work with custom resources.The added code follows the same pattern as the code that handles
Nodesubclasses. ForNodesubclasses, however, the existing code does some extra work we don't need for resources, such as recursing into the Node's children and scanning for related AnimationPlayers.