Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slashJoin() enhancement #45

Merged
merged 6 commits into from
Oct 23, 2015
Merged

slashJoin() enhancement #45

merged 6 commits into from
Oct 23, 2015

Commits on Oct 23, 2015

  1. modified slashJoin() to maintain trailing slashes in the path of a UR… 

    …L if they are already there, if they aren't there, we don't want to add it. This PR adds logic to handle this properly. Please see issue gonzalocasas#43 for reference
    @jlank
    jlank committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    d0fde31 View commit details
    Browse the repository at this point in the history

  2. minor spelling correction

    @jlank
    jlank committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    414d2bb View commit details
    Browse the repository at this point in the history

  3. minor spelling correction

    @jlank
    jlank committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    499d67a View commit details
    Browse the repository at this point in the history

  4. updated tests to reflect correct use of the assert API https://nodejs… 

    ….org/api/assert.html#assert_assert_strictequal_actual_expected_message. The actual and expected parameters were reversed (if I am reading the code right)
    @jlank
    jlank committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    e8bf71b View commit details
    Browse the repository at this point in the history

  5. made slashJoin trailing slash fix without breaking the tests (that we… 

    …ren't already not working off master) - proxy test if stream ended is not working on a fresh clone
    @jlank
    jlank committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    effb1d5 View commit details
    Browse the repository at this point in the history

  6. updated tests to reflect correct use of the assert API https://nodejs… 

    ….org/api/assert.html#assert_assert_strictequal_actual_expected_message. The actual and expected parameters were reversed (if I am reading the code right)
    @jlank
    jlank committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    404ac4f View commit details
    Browse the repository at this point in the history