Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding x86 architecture to GH actions causes two tests to fail #453

Closed
amartinhuertas opened this issue Nov 16, 2020 · 2 comments
Closed

Adding x86 architecture to GH actions causes two tests to fail #453

amartinhuertas opened this issue Nov 16, 2020 · 2 comments
Assignees
@amartinhuertas

Comments

@amartinhuertas
Copy link
Member

More details here:

https://github.com/gridap/Gridap.jl/runs/1405739573?check_suite_focus=true#step:6:126
@amartinhuertas amartinhuertas self-assigned this Nov 16, 2020
@fverdugo
Copy link
Member

It seems that the json parser has read some integers as Int64 even in x86.

Try to replace

Gridap.jl/src/ReferenceFEs/CLagrangianRefFEs.jl

Line 157 in 23f56ed

extrusion = Tuple(dict[:extrusion])

by

extrusion = map(Int,Tuple(dict[:extrusion]))

A more elegant way of fixing this would be to configure the json parser to return Int instead of Int64. (Don't know if it is possible)

amartinhuertas added a commit that referenced this issue Nov 17, 2020
@amartinhuertas
Using inttype keyword argument in order to solve the following issue
5ad9300 
#453
@amartinhuertas
Copy link
Member Author

Don't know if it is possible

Yes, it is possible! Solved in PR: #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amartinhuertas amartinhuertas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amartinhuertas @fverdugo