Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window always has padding because of ContentView #1855

Closed
tig opened this issue Jul 18, 2022 · 2 comments
Closed

Window always has padding because of ContentView #1855

tig opened this issue Jul 18, 2022 · 2 comments
Labels

Comments

@tig
Copy link
Collaborator

tig commented Jul 18, 2022

Describe the bug
The Window class contains a ContentView, referenced as 'Client'. This view is positioned at X = Y = 1.

This means that even if you set Window.Border.BorderThickness to 0, there's still a 1 row/column pad.

I think this can be worked around by changing dimensions of Client, but it's annoying.

This may just be a doc issue. I'm filing it so I don't forget.

@BDisp
Copy link
Collaborator

BDisp commented Jul 18, 2022

@tig that can tweaked by setting the DrawMarginFrame to false.

imagem

@tznind
Copy link
Collaborator

tznind commented Jul 18, 2022

Looks like you can't set DrawMargineFrame to false till you first set BorderStyle.None. Also BorderBrush doesn't seem to do anything

border

tznind added a commit to gui-cs/TerminalGuiDesigner that referenced this issue Jul 18, 2022
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Jul 18, 2022
@tig tig added the bug label Jul 19, 2022
@tig tig closed this as completed in 40b661d Jul 19, 2022
tig added a commit that referenced this issue Jul 21, 2022
* trying to make it work

* Fixes #1849. Wizard as non-modal doesn't work

* Fixes #1855. Window and Frame content view without the margin frame.

* Fixing layout of non-modal

* WizardSTep is now a FrameView

* Now use Modal = false to set visual style automatically

* Removed Controls as an explicit construct. Now just Add to WizardStep

Co-authored-by: BDisp <[email protected]>
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Jul 26, 2022
* trying to make it work

* Fixes gui-cs#1849. Wizard as non-modal doesn't work

* Fixes gui-cs#1855. Window and Frame content view without the margin frame.

* Fixing layout of non-modal

* WizardSTep is now a FrameView

* Now use Modal = false to set visual style automatically

* Removed Controls as an explicit construct. Now just Add to WizardStep

Co-authored-by: BDisp <[email protected]>
tig added a commit that referenced this issue Aug 1, 2022
* Fixes #1861. Border Title property is preferable than the Text.

* Fixes #1866. Bug when scrolling text and type in a TextView. (#1868)

* Some fixes for the WebConsole support. (#1865)

* Invoking NotifyStopRunState for all situations.

* Added Clicked property to support web console.

* Changing to MoveDown to stay always visible.

* Fixes #1849. Wizard as non-popup is broken (#1853)

* trying to make it work

* Fixes #1849. Wizard as non-modal doesn't work

* Fixes #1855. Window and Frame content view without the margin frame.

* Fixing layout of non-modal

* WizardSTep is now a FrameView

* Now use Modal = false to set visual style automatically

* Removed Controls as an explicit construct. Now just Add to WizardStep

Co-authored-by: BDisp <[email protected]>

* Update docs with keybindings, global key event and designer (#1869)

* Added docs on keybinding and global key event

* Added TerminalGuiDesigner to showcases/examples

* Regenerated Docs (#1870)

* Fixed cancel logic. Title now shows for non-modal. (#1871)

* Fixes #1874. API docs on github are broken. (#1875)

* Fixes #1874. API docs on github are broken.

* Rebuild with docfx 2.59.3.0 version.

* Fixes Wizard cancel logic and updates docs (#1878)

* Fixed cancel logic. Title now shows for non-modal.

* trying to fix docs

* trying to fix docs

* Fixes #1867. Use Undo and Redo commands with WordWrap enabled. (#1877)

* Updated docs; regeneraged docs (#1881)

* Added a 'Read Only' to the Editor scenario Format menu. (#1882)

* Fixes #1883. Toplevel now propogates Loaded & Ready events to child Toplevel views.

* Updated API doc theme. Added Wizard Sample

* Tweaked API docs format and content. Fixed build warnings.

* Fixes #1889. Docs broken after org move.

* Regen API docs

* Fixes readme links to API docs

* Avoiding breaking change.

* Fixes typos.

* Passing string.Empty to Title from the default constructor.

* Initializes title with string.Empty instead of null.

Co-authored-by: Tig Kindel <[email protected]>
Co-authored-by: Thomas Nind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants