-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1861. Border: Title property is preferable to Text. #1862
Conversation
BDisp
commented
Jul 19, 2022
* Invoking NotifyStopRunState for all situations. * Added Clicked property to support web console. * Changing to MoveDown to stay always visible.
* trying to make it work * Fixes gui-cs#1849. Wizard as non-modal doesn't work * Fixes gui-cs#1855. Window and Frame content view without the margin frame. * Fixing layout of non-modal * WizardSTep is now a FrameView * Now use Modal = false to set visual style automatically * Removed Controls as an explicit construct. Now just Add to WizardStep Co-authored-by: BDisp <[email protected]>
* Fixes gui-cs#1874. API docs on github are broken. * Rebuild with docfx 2.59.3.0 version.
* Fixed cancel logic. Title now shows for non-modal. * trying to fix docs * trying to fix docs
…hild Toplevel views.
I already have done the merge before but perhaps still having some setting under progress and didn't assumed it. |
@BDisp did you notice I have a question/comment above in my code review? I think this is a breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please either convince me that changing the method signature from string
to ustring
isn't a breaking change or fix this so that it's not a breaking change.
I can´t see it, where? |
|
It only appeared latter :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if you actually thought switching from string
to ustring
was really going to be a breaking change or not. I see that you reverted that, but it's not clear to me whether you did it just because it was easier than arguing or you actually agreed it was a breaking change.
I've added some suggestions on API documentation as well. Thanks.
@tig, is there any problem with this pr? |
I asked for changes: |
Yes, but I already resolved. Did I do something wrong? |
Sorry, I didn't see this comment before. I agree that will cause a breaking change if the user pass a string variable to the constructor. Passing a literal string wouldn't causing problems. But we must supposed that this class can being used by others users and reverting was the best solution. So, in the Initialize method I cast it to
I think I already did the suggestions changes. Thanks. |
I don't know if it's a work around for the #1827. |