Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT/CHORE] Update babel to 2.14 #4904

Merged
merged 5 commits into from
Dec 15, 2023
Merged

[CONTENT/CHORE] Update babel to 2.14 #4904

merged 5 commits into from
Dec 15, 2023

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Dec 13, 2023

Fixes #4761

Sadly Tagalog/ᜆᜄᜎᜓᜄ᜔ (ISO: tl) remains unsupported for now, so I left that override in place, meaning that all babel-translated content (like UI elements) will remain in English for now.

Our own yaml content like adventures and keywords is shown properly because we grab it from the yamls ourselves without babel.

How to test

Navigate to the site in Setswana and verify all still works: http://127.0.0.1:8080/hedy?language=tn#default (and similarly for Papiamentu)

Also observe that the one word I translated (Home) is now shown:

image

@Felienne Felienne requested a review from jpelay December 13, 2023 16:50
@ghost
Copy link

ghost commented Dec 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne Felienne changed the title [CONTENT] Update babel to 2.14 [CONTENT/CHORE] Update babel to 2.14 Dec 13, 2023
@jpelay
Copy link
Member

jpelay commented Dec 14, 2023

Hi, I must be doing something wrong here, because after a pip install it breaks the page

image

@Felienne
Copy link
Member Author

Ow I think that is an (unrelated) CSS issue that exists/existed in main (I think @hasan-sh knows that caused that)

Can you try running the dev css and see if that helps?

@Felienne
Copy link
Member Author

Should work again now @jpelay! Somehow main was missing all css but that has been solved.

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now!!!! Thanks! And thanks @rix0rrr for the Babel PR that made this support possible

'tl': 'en'}

# For the non-existing language manually overwrite the display language to make sure it is displayed correctly
CUSTOM_LANGUAGE_TRANSLATIONS = {'kmr': 'Kurdî (Tirkiye)',
'tn': 'Setswana',
'pap': 'Papiamentu',
'tl': 'ᜆᜄᜎᜓᜄ᜔'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that these languages, even having large speaking communities, are not officially supported.

Copy link
Contributor

mergify bot commented Dec 15, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8826497 into main Dec 15, 2023
11 checks passed
@mergify mergify bot deleted the update-babel branch December 15, 2023 14:44
Copy link
Contributor

mergify bot commented Dec 15, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CONTENT] Update babel
2 participants