-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONTENT/CHORE] Update babel to 2.14 #4904
Conversation
Ow I think that is an (unrelated) CSS issue that exists/existed in main (I think @hasan-sh knows that caused that) Can you try running the dev css and see if that helps? |
Should work again now @jpelay! Somehow main was missing all css but that has been solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works now!!!! Thanks! And thanks @rix0rrr for the Babel PR that made this support possible
'tl': 'en'} | ||
|
||
# For the non-existing language manually overwrite the display language to make sure it is displayed correctly | ||
CUSTOM_LANGUAGE_TRANSLATIONS = {'kmr': 'Kurdî (Tirkiye)', | ||
'tn': 'Setswana', | ||
'pap': 'Papiamentu', | ||
'tl': 'ᜆᜄᜎᜓᜄ᜔'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad that these languages, even having large speaking communities, are not officially supported.
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #4761
Sadly Tagalog/ᜆᜄᜎᜓᜄ᜔ (ISO: tl) remains unsupported for now, so I left that override in place, meaning that all babel-translated content (like UI elements) will remain in English for now.
Our own yaml content like adventures and keywords is shown properly because we grab it from the yamls ourselves without babel.
How to test
Navigate to the site in Setswana and verify all still works: http://127.0.0.1:8080/hedy?language=tn#default (and similarly for Papiamentu)
Also observe that the one word I translated (Home) is now shown: