Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge public repo updates to master branch #4

Merged
merged 22 commits into from
Sep 18, 2018
Merged

Conversation

hosunmsft
Copy link
Owner

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

khughes66 and others added 22 commits September 13, 2018 15:51
… API" (#3856)

* -Publish "Azure metrics REST Ingestion API" public preview swagger spec

* Address review comments
 - Use a shorter operationId
 - Remove any non-success response code with default response clause
 - Add a new example and reference it in the swagger spec
 - Include readme.md file for the swagger spec

* Fix a bug in readme.md.
 - Inline the readme.python.md file in the readme.md

* -Remove validation section that is not necessary

* -Address review comments & fix several copy paste mistakes to use sensible names instead

* Address the PR comments
  - Fix the readme.md naming incompatibilities
  - Remove the c#-ish namespace prefix

* -Remove assembly namespace prefix in few other places
-Rename bunch of properties to follow camel case naming
-Update the enum types to have the "x-ms-enum" part of the json

* -Fix last batch of ARM Errors
-Update path and namespace for Java section

* -Drop all the types that recursively came with ObjectResult and use simple object type instead. This should make the swagger spec clean and more easily maintainable in the long run

* -Fix the example to just follow key-value pairs for all required parameters.

* -Fix the responses section in the example

* -Fix the type bug in the example, use int32 instead of string
* add 202 response code as expected for network profile deletion

add 202 to delete example

* added 200 response code for network profile
…orage" and new feature fileaadIntegration (#3864)

* [Storage] Add api version 2018-07-01

* [Storage] update api version 2018-07-01

* [Storage] Add new Storage Account Kind and Sku

* [Storage] Remove the sku Premium_ZRS change as it won't be release in Ignite

* [Storage] Support FileAadIntegration

* Storage Python conf

* [Storage] modify per comments

* [Storage] Add the parameter location changes in 2018-03-01-preview to 2018-07-01

* [Storage] Add back Management Policy from 2017-03-01-preview

* [Storage] remove global usage as server change

* [Storage] Add new Sku Premium_ZRS

* [Storage] move Management policy swagger to 2018-03-01-preview folder
* Fix to version in examples and in runbook.json

* Added new 2018-06-30 tag to readme and other nit fixes

* Added missing property to make JobStreamProperties definitions identical
* Add readme.typescript.md for DNS

* Add azure-sdk-for-js swagger-to-sdk entry in DNS readme.md
…entaiton generation works as expected (#3911)

* -Publish "Azure metrics REST Ingestion API" public preview swagger spec

* Address review comments
 - Use a shorter operationId
 - Remove any non-success response code with default response clause
 - Add a new example and reference it in the swagger spec
 - Include readme.md file for the swagger spec

* Fix a bug in readme.md.
 - Inline the readme.python.md file in the readme.md

* -Remove validation section that is not necessary

* -Address review comments & fix several copy paste mistakes to use sensible names instead

* Address the PR comments
  - Fix the readme.md naming incompatibilities
  - Remove the c#-ish namespace prefix

* -Remove assembly namespace prefix in few other places
-Rename bunch of properties to follow camel case naming
-Update the enum types to have the "x-ms-enum" part of the json

* -Fix last batch of ARM Errors
-Update path and namespace for Java section

* -Drop all the types that recursively came with ObjectResult and use simple object type instead. This should make the swagger spec clean and more easily maintainable in the long run

* -Fix the example to just follow key-value pairs for all required parameters.

* -Fix the responses section in the example

* -Fix the type bug in the example, use int32 instead of string

* -Fix the swagger spec to ensure the documentation content is rendered as expected.

* -Fix the readme.md file to refer the correct file

* -Delete the old spec as it is now renamed

* -Call operationId with suffix Create to be consistent
-Rename the file to be consistent with operationId
* Add specifications for dynanic threshold GA api

* Change to capital letter and capitalizing abbreviations

* Add metricnamespace & $filter parameters
* Introducing new API for Advanced Threat Protection

API form -
{resourceUri}/providers/Microsoft.Security/advancedThreatProtectionSettings/{settingName}

Suppporting verbs -
GET, PUT and Delete.

URI example -
/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/resourceGroups/SampleRG/providers/Microsoft.Storage/storageAccounts/samplestorageaccount/providers/Microsoft.Security/advancedThreatProtectionSettings/current

Design doc for ATP -
https://microsoft.sharepoint.com/teams/Data_Security/Documents/Dev%20Specs/Storage%20Threat%20Detection/Threat%20Detection%20for%20Azure%20Storage%20-%20Design%20Document.docx?d=w996c55b5a160468c9a9bd0434418a4d0

* Addressing pull request comments

*Removed DELETE operation, stayed only with GET and PUT.
*Changed ResourceUri to ResourceId
*Changed isEnabled to enabled

* Renaming obejct from AdvancedThreatProtectionSettings to AdvancedThreatProtectionSetting

* Removed delete operation from the swagger definitions

* Fixed test failures

* Changing "AdvancedThreatProtectionSettingName" parameter to enum type

* Changed param name from 'enabled' to 'isEnabled'
…3876)

Added Data_Exfiltration and Unsafe_Action as allowed values to disabled alert.
…3910)

* Add BatchAIWorkspace to main swagger and examples

* Fix whitespace

* Update casing to match swagger definition

* Correctly update casing of all usages of batchaiWorkspace
* Add networkTrace resource and APIs

* Add examples of network trace APIs

* Add x-ms-examples to network trace APIs

* Fix file name typo of GetWebSiteNetworkTraces.json

* Fix syntax error in examples/GetWebSiteNetworkTraces.json

* Fix more validation errors

* Fix StopWebSiteNetworkTrace.json

* Fix network trace APIs
* Add creation parameters

* Example update

* Fix RegisteredServer
* Add readme.typescript.md for compute

* Change readme.typescript.md header to TypeScript
* Create arm-network readme.typescript.md file

* Add generate-metadata: true to network/resource-manager readme.typescript.md file
* Microsoft.Backup.Admin copy API version 2018-09-01 from 2016-05-01

* Update Microsoft.Backup.Admin API version 2018-09-01

* resolve comments
* Add degreeOfParallelismPercent to JobInformationBasic

* Add degreeOfParallelismPercent to JobInformationBasic

* add degreeOfParallelism to preview API
:wq
:wq
�
… version 2018-07-01 (#3927)

* Clone existing ApiVersion 2018-07-01

* Change folder structures and remove versions from readme*

* Review comments incorporation.

* Add go

* one tag only

* fix version
@hosunmsft hosunmsft merged commit 4caaa8a into hosunmsft:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.