Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LUKSO Cancun Hardfork #7686

Merged
merged 26 commits into from
Sep 30, 2024

Conversation

Wolmin
Copy link
Contributor

@Wolmin Wolmin commented Sep 27, 2024

PR description

The LUKSO Mainnet Dencun Hardfork is scheduled for Wednesday, 20 November 2024 16:20:00 - the cancunTime (1732119595) is calculated to start 5s before Deneb Fork Epoch start time (first slot of 123075 epoch is 3938400, its timestamp is 1732119600).

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

fab-10
fab-10 previously requested changes Sep 27, 2024
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the DCO, see https://wiki.hyperledger.org/display/BESU/DCO, and add a CHANGELOG entry

Wolmin and others added 23 commits September 27, 2024 15:14
I am no longer aligned with the Governance policies and practices of
LFDT and resign my position as maintainer.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Wolmin <[email protected]>
* create separate signature class for code delegations as they have different bound checks

Signed-off-by: Daniel Lehrner <[email protected]>

* test if increasing xmx let's failing acceptance test pass

Signed-off-by: Daniel Lehrner <[email protected]>

* javadoc

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Wolmin <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Co-authored-by: Stefan Pingel <[email protected]>
Signed-off-by: Wolmin <[email protected]>
…7631)

* Don't persist IBFT2 proposal blocks, just validate them

Signed-off-by: Matthew Whitehead <[email protected]>

* Tidy up changelog

Signed-off-by: Matthew Whitehead <[email protected]>

---------

Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matt Whitehead <[email protected]>
Signed-off-by: Wolmin <[email protected]>
* Dev mode for short BFT block periods

Signed-off-by: Matthew Whitehead <[email protected]>

* Refactoring

Signed-off-by: Matthew Whitehead <[email protected]>

* Fix comment

Signed-off-by: Matthew Whitehead <[email protected]>

* Refactor to make BFT block milliseconds an experimental QBFT config option

Signed-off-by: Matthew Whitehead <[email protected]>

* Update Json BFT config options

Signed-off-by: Matthew Whitehead <[email protected]>

---------

Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Wolmin <[email protected]>
Signed-off-by: Blue <[email protected]>
Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Wolmin <[email protected]>
* yParity is valid  up to 2**256 as well

Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Wolmin <[email protected]>
* remove integration tests related to privacy

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Wolmin <[email protected]>
* Update entrypoint script for Dockerfile to only switch user if its running as root

Signed-off-by: Rafael Matias <[email protected]>

* make root user check at the beginning

Signed-off-by: Rafael Matias <[email protected]>

---------

Signed-off-by: Rafael Matias <[email protected]>
Signed-off-by: Wolmin <[email protected]>
* Include consolidationRequestContract in jsonGenesisConfigOptions

Signed-off-by: gconnect <[email protected]>

* Update changelog and ran spotlessApply

Signed-off-by: gconnect <[email protected]>

* Rename consolidationRequestPredeployAddress to consolidationRequestContractAddress

Signed-off-by: gconnect <[email protected]>

* Create request contract addresses class

Signed-off-by: gconnect <[email protected]>

* Update method calls

Signed-off-by: gconnect <[email protected]>

* Refactor RequestContractAddresses class and update method calls and test

Signed-off-by: gconnect <[email protected]>

---------

Signed-off-by: gconnect <[email protected]>
Co-authored-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Wolmin <[email protected]>
…ledger#3810) (hyperledger#6965)

Implemented support for emptyBlockPeriodSeconds in QBFT (Issue hyperledger#3810)

Introduces experimental xemptyblockperiodseconds genesis config option for producing empty blocks at a specific interval independently of the value of the existing blockperiodseconds setting.

hyperledger#3810

---------

Signed-off-by: Antonio Mota <[email protected]>
Signed-off-by: amsmota <[email protected]>
Signed-off-by: Wolmin <[email protected]>
Set RELEASE_NAME as environment variable for the step

Signed-off-by: Chaminda Divitotawela <[email protected]>
Signed-off-by: Wolmin <[email protected]>
@macfarla macfarla dismissed fab-10’s stale review September 30, 2024 01:22

requested changes have been made

@fab-10 fab-10 enabled auto-merge (squash) September 30, 2024 06:56
@macfarla
Copy link
Contributor

@Wolmin you'll need to resolve the conflicts before this can be merged - your branch is locked down too so we can't push to it

@fab-10 fab-10 enabled auto-merge (squash) September 30, 2024 10:03
@fab-10 fab-10 merged commit 6fc75c0 into hyperledger:main Sep 30, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.