Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated offsets for hat visibility and visor/weapon drawn/visible flags. #1378

Merged

Conversation

CaptainSticky
Copy link
Contributor

This pull request updates two offsets. The first is for the hat visibility toggle, and the second is for characters flags which relate to weapon visibility/drawn and visor state. Math was done.

@ergoxiv
Copy link
Contributor

ergoxiv commented Aug 19, 2024

Yeah, these are the correct offsets but the hat toggle doesn't seem to work properly. It gets written to by the button's data binding and then the value flips back to it's old state after WriteDelayedBinds() gets called.

@CaptainSticky
Copy link
Contributor Author

I can't seem to get this to happen for me. I've turned off both Brio and Penumbra integration and log'd out when WriteDelayedBinds is done. It seemed okay when I toggled it both from the game and from Ana. How did you get this behavior?

@ergoxiv
Copy link
Contributor

ergoxiv commented Aug 19, 2024

Toggling visibility through Anamnesis' equipment editor. I tried both with and without integration but for me this issue occurs on both. If it's only me then it might be Glamourer causing issues though I was under the impression I had it disabled. I'll check once I get home.

@CaptainSticky
Copy link
Contributor Author

Oooh! I think it's because I don't use Glamourer. I installed it and was able to reproduce the issue... and strangely, only with that one thing. The same issue occurs with both Brio and Ktisis.

@StoiaCode
Copy link
Contributor

That's to be expected. Glamourer needs to be disabled in order for Anamnesis to work properly. The two are inherently editing two different parts of memory that when brought into disharmony will fight over who is correct.

@StoiaCode
Copy link
Contributor

Just got to test aroudn, im curious now what was broken with the Weapons? Im probably missing something, but the draw weapon and visibility toggle both work to me in current Ana, no?

@CaptainSticky
Copy link
Contributor Author

CaptainSticky commented Aug 24, 2024

The byte that Ana uses to control whether the weapon (main hand only it seems?) is visible is on the weapon memory. However, the byte used for toggling visor state also, according to the existing code and client structs, has visibility into the weapon state (visibility and being drawn.) In short, this change shouldn't affect those these, since the two character flags bytes are only being affected for hat visibility and visor state.

@StoiaCode StoiaCode merged commit b0fcfa8 into imchillin:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants