Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-133] simcompare calculate signaltowidth instead of manual input #211

Conversation

quekyj
Copy link
Contributor

@quekyj quekyj commented Nov 30, 2022

Description & Motivation

It's annoying and confusing to need to set the signalToWidth map for SimCompare after already setting port widths properly.

Related Issue(s)

Fix #133

Testing

No new unit test been created.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Yes. signalToWidth parameter is no longer supported while Module must be provided to the simcompare.iverilogVector().

Documentation

Nope.

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few changes

lib/src/utilities/simcompare.dart Outdated Show resolved Hide resolved
lib/src/utilities/simcompare.dart Outdated Show resolved Hide resolved
lib/src/utilities/simcompare.dart Outdated Show resolved Hide resolved
@quekyj quekyj changed the title [Issue #133] - simcompare calculate signaltowidth instead of manual input [Issue-133] - simcompare calculate signaltowidth instead of manual input Dec 1, 2022
@quekyj quekyj changed the title [Issue-133] - simcompare calculate signaltowidth instead of manual input [Issue-133] simcompare calculate signaltowidth instead of manual input Dec 1, 2022
@quekyj quekyj requested a review from mkorbel1 December 1, 2022 05:53
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment that I reopened, other than that looks good!

@eric-norige
Copy link
Contributor

Just the one comment that I reopened, other than that looks good!

Good catch; I learned that github reviews can show you old versions of code, and I think I reviewed an old version. I agree that null is better than '' for "no parameter passed". This probably means that '' should be checked for and an error reported.

@quekyj quekyj requested a review from mkorbel1 December 2, 2022 00:02
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mkorbel1
Copy link
Contributor

mkorbel1 commented Jan 5, 2023

I think since this isn't part of the public API, let's count this as not backwards-compatibility-breaking, especially since migrating for those who are using it is just a matter of deleting some information.

Can you get this branch back up through merge conflicts and then we can merge it in?

@quekyj
Copy link
Contributor Author

quekyj commented Jan 6, 2023

@mkorbel1 I resolved the merge conflict, do let me know if need anything else.

@mkorbel1
Copy link
Contributor

mkorbel1 commented Jan 6, 2023

Looks like you pulled in all the website changes as well into this branch? Then we should either revert that so it's just simcompare in here or else merge the website first

@quekyj
Copy link
Contributor Author

quekyj commented Jan 8, 2023

Aww, I will remove the website. Looks like there were some mistakes there during my commit.

@quekyj quekyj force-pushed the 133-simcompare-calculate-signaltowidth-instead-of-manual-input branch from be69868 to 0d756e3 Compare January 9, 2023 07:51
@quekyj quekyj requested a review from mkorbel1 January 9, 2023 08:04
@quekyj
Copy link
Contributor Author

quekyj commented Jan 9, 2023

@mkorbel1 I think it should be good to go now. I reset to previous unpolluted commit and remerge.

test/conditionals_test.dart Outdated Show resolved Hide resolved
@quekyj quekyj requested a review from mkorbel1 January 20, 2023 03:43
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@mkorbel1 mkorbel1 merged commit 6508c6e into intel:main Jan 24, 2023
@quekyj quekyj deleted the 133-simcompare-calculate-signaltowidth-instead-of-manual-input branch February 2, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In SimCompare calculate the signalToWidthMap instead of manually inputting in iverilogVector
3 participants