-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: ion-reorder-group broken when iterating custom components. #19447
Comments
This issue has been labeled as If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort. For a guide on how to create a pull request and test this project locally to see your changes, see our contributing documentation. Thank you! |
Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. Thank you for using Ionic! |
resolves #19447 Co-authored-by: Gwe-n <[email protected]>
Thanks for the issue. This has been resolved via #26289, and a fix will be available in an upcoming release of Ionic Framework. |
Bug Report
Ionic version:
[x] 4.x
Current behavior:
See previous issue that was closed: #7425
I'm trying to use
ion-reorder-group
. Previously I was iterating withion-item-sliding
for my child elements and everything worked fine. I refactored my code so that theion-item-sliding
and all descendant nodes are part of a new componentcg-layer-select-item
.When I click and drag the
ion-reorder
component, I do not see my custom element "lift" itself out of the collection and begin the reordering process. If I drag my finger and try to move the item anyway, it tends to end up at the end of myion-reorder-group
, with the reorder eventdetail
looking like{ from: 1, to: 10 }
where10
is the last slot in the group.Expected behavior:
I expect to be able to reliably reorder custom components with full animation support.
Steps to reproduce:
Sample app: https://stackblitz.com/edit/ionic-v4-angular-tabs-a5ezqv
Note there are TWO
ion-list
s with a direct childion-reorder-group
. The difference between the two is that one usesion-item
as a child, the other a custom component. Theion-item
version works fine, but the custom component version does not.Ionic info:
The text was updated successfully, but these errors were encountered: