Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-reorder-group broken when iterating custom components. #19447

Closed
marpstar opened this issue Sep 25, 2019 · 3 comments · Fixed by #26289
Closed

bug: ion-reorder-group broken when iterating custom components. #19447

marpstar opened this issue Sep 25, 2019 · 3 comments · Fixed by #26289
Labels
help wanted a good issue for the community package: core @ionic/core package type: bug a confirmed bug report

Comments

@marpstar
Copy link
Contributor

Bug Report

Ionic version:

[x] 4.x

Current behavior:

See previous issue that was closed: #7425

I'm trying to use ion-reorder-group. Previously I was iterating with ion-item-sliding for my child elements and everything worked fine. I refactored my code so that the ion-item-sliding and all descendant nodes are part of a new component cg-layer-select-item.

When I click and drag the ion-reorder component, I do not see my custom element "lift" itself out of the collection and begin the reordering process. If I drag my finger and try to move the item anyway, it tends to end up at the end of my ion-reorder-group, with the reorder event detail looking like { from: 1, to: 10 } where 10 is the last slot in the group.

Expected behavior:

I expect to be able to reliably reorder custom components with full animation support.

Steps to reproduce:

Sample app: https://stackblitz.com/edit/ionic-v4-angular-tabs-a5ezqv

Note there are TWO ion-lists with a direct child ion-reorder-group. The difference between the two is that one uses ion-item as a child, the other a custom component. The ion-item version works fine, but the custom component version does not.

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.12.0
   Ionic Framework               : @ionic/angular 4.9.1
   @angular-devkit/build-angular : 0.13.6
   @angular-devkit/schematics    : 7.3.6
   @angular/cli                  : 7.3.6
   @ionic/angular-toolkit        : 1.4.0
@ionitron-bot ionitron-bot bot added the triage label Sep 25, 2019
@brandyscarney brandyscarney added help wanted a good issue for the community package: core @ionic/core package labels Oct 8, 2019
@ionitron-bot
Copy link

ionitron-bot bot commented Oct 8, 2019

This issue has been labeled as help wanted. This label is added to issues that we believe would be good for contributors.

If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.

For a guide on how to create a pull request and test this project locally to see your changes, see our contributing documentation.

Thank you!

@ionitron-bot
Copy link

ionitron-bot bot commented Oct 7, 2020

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

Thank you for using Ionic!

@ionitron-bot ionitron-bot bot closed this as completed Oct 7, 2020
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 7, 2020
@liamdebeasi liamdebeasi reopened this Nov 7, 2022
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report and removed package: core @ionic/core package labels Nov 7, 2022
liamdebeasi added a commit that referenced this issue Nov 17, 2022
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #26289, and a fix will be available in an upcoming release of Ionic Framework.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted a good issue for the community package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
3 participants