Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reorder-group): support custom components #26289

Merged
merged 8 commits into from
Nov 17, 2022
Merged

fix(reorder-group): support custom components #26289

merged 8 commits into from
Nov 17, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 15, 2022

⚠️ Give co-author credit to https://github.com/Gwe-n when merging.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #19447

The parent container that gets dragged needs display: block in order for the transform values to render correctly. This is not a problem when just using ion-reorder and ion-item as both have display: block, but if you wrap these in a custom component the reorder effect breaks because that component does not have display: block.

What is the new behavior?

  • Custom components now receive display: block when used inside of ion-reorder-group
  • I also took this opportunity to migrate the other reorder group tests to playwright to better verify that I am not regressing any behavior.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the title Fw 2752 fix(reorder-group): support custom components Nov 15, 2022
@github-actions github-actions bot added the package: core @ionic/core package label Nov 15, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 15, 2022 16:52
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 15, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-reorder-group broken when iterating custom components.
2 participants