Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reorder-group) : Adaptation when it is contained in a component #21747

Closed
wants to merge 1 commit into from

Conversation

Gwe-n
Copy link
Contributor

@Gwe-n Gwe-n commented Jul 13, 2020

Fixes #19447

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19447

What is the new behavior?

The OnStart function of the component reorder-group.tsx has been adapted to handlethe case where the "ion-item" is contained in a Custom Component.

Capture d’écran 2020-07-14 à 00 31 25

Enregistrement de l’écran 2020-07-14 à 00 41 25

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jul 13, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the PR and apologies for the delay. We appreciate all the work you put into creating this PR. We are interested in accepting this fix, but we would like to sync the change with the latest code in main and add tests. As a result, I am going to close this PR in favor of a new PR in #26289. I will give you co-author credit if this new PR is merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-reorder-group broken when iterating custom components.
2 participants