merge master again #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(danger): warn only for non conventional changelog
* docs(bindCallback): fix typo * docs(bindNodeCallback): fix typo * docs(max): add missing param name * docs(min): add missing param name * docs(multicast): add missing param names * docs(publish): add missing param name * docs(repeat): remove non-existent `scheduler` param * docs(reduce): remove redundant, ignored `@return` tag * docs(retry): add missing param name and improve description * docs(repeatWhen): fix docs Fixes include: - Remove non-existent `scheduler` param. - Add missing param name and type for `notifier`. - Fix some typos. - Improve description (model after `retryWhen` for consistency). fixup! docs(repeatWhen): fix docs * docs(single): add missing param name * docs(retryWhen): fix docs Fixes include: - Remove non-existent `scheduler` param. - Add missing param name and type for `notifier`. - Fix some typos. - Improve description. * docs(skip): add missing param name * docs(skipUntil): add missing param name * docs(startWith): fix docs Fixes include: - Add missing, optional param `scheduler`. - Add missing param name for `values`. - Change param type (`Values` --> .`..T`) and description (new description based on that of `Observable#of()`). * docs(subscribeOn): add missing param name * docs(switchMapTo): remove redundant, ignored `@return` tag * docs(throw): fix typo * docs(*): ensure param descriptions are capitalized
…tiveX#2396) If the user is relying on indicies starting at 1 than this could be a BC. Otherwise now it's compatible with RxJS 4.
…X#2390) Flesh out what is an Observable Contract. Add note about returning TeardownLogic in passed function. Change 'subscribe' to 'onSubscription' so that there is no confusion when function is called. Switch Subscriber instance as a function argument to Observer interface, so that users are not encouraged to use Subscribers implementation details. Add note about TS signature issue. Add examples with calling observers error and returning teardown logic. Do not mark function passed to create as optional, since subscribing to Observable created in such way will throw an Error.
…plementing Symbol.observable (ReactiveX#2387) When static concat is called with single lower case observable, adapt it to RxJS Observable, so that operator would always return an Observable instance.
…tiveX#2386) Add more details about what parameters operator accepts, how it will behave with empty and never Observables, how it relates to merge operator, how it will deal with errors from input Observables and note that it can accept the same Observable many times.
…eactiveX#2380) Add usage description and examples for four publicly available schedulers, so that users have better intuition how they will behave when used in operators.
…activeX#2351) Add more about when combineLatest emits, completes and errors. Add information about different ways it can be called and different paramteres it accepts. Provides examples of different ways operator can be called.
… a scheduler is provided (ReactiveX#2344) When operator is passed a scheduler, use that scheduler to call error in observer when error object is passed to callback or calling input function fails, so that all kinds of errors cause the same behaviour.
Add more in depth descriptions about various modes of operator usage and potential problems involded. Add more examples illustrating points in the description. Add references and comparisons to other similar operators. Add note about using schedulers to control operator. Describe when input function is actually called.
* documentation(zip) Fixed typo in the zip operator docstring * style(lint): remove trailing whitespace
…r operators (ReactiveX#2322) Compare bindCallback to similar operators like bindNodeCallback and fromEvent to emphasize how operator works. Add description and example of using with functions that call callback with multiple parameters. Add note about optional selector function and example with selector used. Add description and example how using async scheduler can change operator behaviour. Add note when input function is actually called.
We want to log the input values and not the keypress events.
fix(ErrorObservable): remove type constraint to error value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.