Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument name "obj" in generated wrapper file exports seems wrong #54

Closed
domenic opened this issue Aug 19, 2017 · 1 comment
Closed

Argument name "obj" in generated wrapper file exports seems wrong #54

domenic opened this issue Aug 19, 2017 · 1 comment

Comments

@domenic
Copy link
Member

domenic commented Aug 19, 2017

In particular we accept any value, not just objects. I will document it as value for now in #51.
@TimothyGu
Copy link
Member

I'm okay with making that change. Something to be aware of is that value as a variable name is already used very often, so perhaps a different name is needed.

domenic added a commit that referenced this issue Aug 20, 2017
@domenic
Expand documentation
4c53388 
Now includes the generated wrapper class file API, guidance on writing implementation class files, and documentation for the generated utils.js file.

See #52, #53, #54, #55, and #56 for oddities discovered during the course of writing this, which we hope to clean up later. (Many of them having to do with functionality that should not be considered public, and as such is not documented here, but is exposed as if it were public.)
domenic added a commit that referenced this issue Apr 17, 2020
@domenic
Add new() export for interfaces
e403a3a 
Since I had to do some refactoring to reduce duplication anyway, this also includes general cleanup to the output, such as replacing obj with either value or wrapper, using arrow functions for our exports, and such. Closes #54.

Closes #193.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @TimothyGu