-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't export most things, for mixins #55
Comments
Are there examples of interfaces defined with NoInterfaceObject but is not a mixin? |
A few legacy ones. E.g. https://html.spec.whatwg.org/#external |
Now includes the generated wrapper class file API, guidance on writing implementation class files, and documentation for the generated utils.js file. See #52, #53, #54, #55, and #56 for oddities discovered during the course of writing this, which we hope to clean up later. (Many of them having to do with functionality that should not be considered public, and as such is not documented here, but is exposed as if it were public.)
In that case, could we specifically flag the few NoInterfaceObject non-mixin interfaces and default to the mixin behavior for NoInterfaceObject? I could see the argument against this of course but just thought it might cause less churn. |
I think I'd rather tag the mixins since we're going to eventually make mixins first class in Web IDL anyway so it'd be nice to get a sense of which ones they are. |
Sounds just fine to me. |
Is this supposed to be closed? Because README.md says that this is still an issue: Line 130 in 9f103a2
Also, #68’s description says that it doesn’t fix this. |
Yeah, that’s because you wrote |
Fixed in #135. Interface mixins don’t cause files to be generated. |
See also #53. is/isImpl and maybe mixedInto make sense. But most of the rest of the exports don't.
To reliably identify a mixin, we can either wait for whatwg/webidl#363 or we can use a custom extended attribute in the meantime.
The text was updated successfully, but these errors were encountered: