Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convertInherited for dictionaries should be _convertInherited #56

Closed
domenic opened this issue Aug 19, 2017 · 0 comments · Fixed by #184
Closed

convertInherited for dictionaries should be _convertInherited #56

domenic opened this issue Aug 19, 2017 · 0 comments · Fixed by #184

Comments

@domenic
Copy link
Member

domenic commented Aug 19, 2017

It's not "public" for consumers of the generated wrapper class; it's used by webidl2js only.
domenic added a commit that referenced this issue Aug 20, 2017
@domenic
Expand documentation
4c53388 
Now includes the generated wrapper class file API, guidance on writing implementation class files, and documentation for the generated utils.js file.

See #52, #53, #54, #55, and #56 for oddities discovered during the course of writing this, which we hope to clean up later. (Many of them having to do with functionality that should not be considered public, and as such is not documented here, but is exposed as if it were public.)
@domenic domenic mentioned this issue Sep 30, 2017
Merged
@ExE-Boss ExE-Boss mentioned this issue Mar 26, 2020
Merged
TimothyGu pushed a commit that referenced this issue Mar 26, 2020
@ExE-Boss
Rename convertInherit in generated dictionary files
36bd91c 
Fixes #56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(dictionary): Rename convertInherit ExE-Boss/webidl2js
1 participant
@domenic