Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/fix python sdk #296

Merged
merged 3 commits into from
Apr 26, 2024
Merged

x/fix python sdk #296

merged 3 commits into from
Apr 26, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Apr 26, 2024


🚀 This description was created by Ellipsis for commit 80c53d3

Summary:

This PR includes a wide range of updates, fixes, and enhancements to the Python SDK, TypeScript SDK, GitHub actions, and documentation, along with modifications to configuration files and a test file.

Key points:

  • Updated and fixed various aspects of the Python SDK.
  • Made changes to the TypeScript SDK.
  • Updated GitHub actions and documentation.
  • Modified configuration files pyproject.toml and pytype.toml.
  • Updated a test file test_example.py.

Generated with ❤️ by ellipsis.dev

Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 80c53d3
  • Looked at 326 lines of code in 13 files
  • Took 2 minutes and 37 seconds to review
More info
  • Skipped 2 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. sdks/python/julep/api/client.py:831:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    The PR description mentions disabling model-serving by default, but the code changes do not reflect this. Please ensure that the PR description aligns with the actual code changes.
  • Reasoning:
    The PR description mentions disabling model-serving by default, but the code changes in the PR do not reflect this. It's important to ensure that the PR description aligns with the actual code changes to avoid confusion and ensure that all intended updates are correctly implemented.

Workflow ID: wflow_xuqShy6jInZOZpuP


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant