Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agents-api): Add jinja templates support #300

Merged
merged 4 commits into from
Apr 26, 2024
Merged

feat(agents-api): Add jinja templates support #300

merged 4 commits into from
Apr 26, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Apr 26, 2024 •
edited by ellipsis-dev bot
Loading

🚀 This description was created by Ellipsis for commit 3e6ccac

Summary:

This PR introduces Jinja templates support in the agents-api and updates both Python and TypeScript SDKs to handle this new feature, along with various other fixes, documentation updates, and dependency bumps.

Key points:

  • Added support for Jinja templates in agents-api.
  • Updated Python SDK to allow render_templates field when creating a session.
  • Updated TypeScript SDK to support render_templates field.
  • Updated test files for both SDKs to test new functionality.
  • Included various fixes, documentation updates, and dependency bumps.

Generated with ❤️ by ellipsis.dev

ellipsis-dev[bot]
ellipsis-dev bot reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 3e6ccac
  • Looked at 916 lines of code in 16 files
  • Took 1 minute and 9 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. agents-api/agents_api/models/session/patch_session.py:19:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    The render_templates field is not supported in the patch_session_query and update_session_query functions. This could lead to inconsistencies in session management where the field can be set but not updated. Consider implementing this feature to ensure full functionality.

Applicable to:

  • agents-api/agents_api/models/session/update_session.py
  • Reasoning:
    The PR introduces support for rendering Jinja templates in session messages based on a new field render_templates. However, the patch_session_query and update_session_query functions have a TODO comment indicating that support for updating the render_templates field is not yet implemented. This could lead to inconsistencies where the field can be set initially but not updated later, which might be confusing or problematic for users relying on this feature.

Workflow ID: wflow_S5qLHpukf0MzhB8r

Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@creatorrr creatorrr merged commit 2850cf4 into dev Apr 26, 2024
9 checks passed
@creatorrr creatorrr deleted the f/jinja-templates branch April 26, 2024 17:21
@creatorrr creatorrr mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@creatorrr