Fix missing symbols on CoreKiwix.xcframework #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libpsl is a lib that provides the Public Suffix List: the list of all TLDs. It's an optional feature of libcurl that we dont need for libkiwix. Leaving it included causes issues when compiling for apple_all_static on x86_64 as libpsf is installed (and thus found by libcurl's configure) but is obviously only for x86_64. An alternative could be to either cross-compile it first and properly reference that version. That sounds like too much effort for a feature we know we dont need. https://github.com/rockdaboot/libpsl
|
Note that this does not fix #764. It I just moved the meson ZIP to dev.kiwix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the libcurl compilation by explicitly disabling PSL and GSS-API for kiwix/kiwix-apple#984
Note that with this there is still an undefined symbol named
SCDynamicStoreCopyProxies.This is apparently macOS-specific and is fixed by linking (dynamically) to
SystemConfiguration.framework.This doesn't seem configurable as this function is used when
CURL_MACOS_CALL_COPYPROXIESis set but this define is not exposed in config but is set based on target.libcurl did not use/call this function in version 7.67.0 which is the one that was used prior to moving to meson.