Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New libkiwix build due to bundled libcurl dep issue #768

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

rgaudin
Copy link
Member

@rgaudin rgaudin commented Oct 18, 2024

macOS 3.6.0 wants to use libkiwix-14.0.0 which is broken on macOS (see kiwix/kiwix-apple#984).
This has been fixed in #765 and @kelson42 requested a new build.

@rgaudin rgaudin requested a review from kelson42 October 18, 2024 14:43
@kelson42 kelson42 merged commit ecd8f98 into main Oct 18, 2024
40 checks passed
@kelson42 kelson42 deleted the libkiwix-14.0.0-1 branch October 18, 2024 15:10
@veloman-yunkan
Copy link
Collaborator

veloman-yunkan commented Oct 22, 2024

I am now investigating a problem with building libcurl under Windows in release mode. I wanted to find out why that problem is not present in our CI. While looking for information in our CI history, issues and PRs, I came across this PR. Sadly, there is absolutely nothing in this PR that helps to understand what the issue was:

  • There is no clue either in the title or in the change itself
  • Description is missing
  • No issue/ticket is linked to this PR

I believe that proper trace is an important part of any change. Though it may be rarely needed, when it's not there at the time of need it may be too difficult to recover.

@veloman-yunkan
Copy link
Collaborator

BTW, it turns out that the Windows build of libkiwix was not created by the CI run caused by this PR. See https://github.com/kiwix/kiwix-build/actions/runs/11405853054/job/31738250419 and https://tmp.kiwix.org/ci/dev_preview/libkiwix-14.0.0-1/. Also there is no Windows build of libkiwix in https://tmp.kiwix.org/ci/dev_preview/libkiwix_14.0.0/ either.

@rgaudin
Copy link
Member Author

rgaudin commented Oct 22, 2024

@veloman-yunkan sorry about that. I just updated the PR but this is a build-request PR so probably not the best place to look for.

Please take a look at #765 where the actual fix hapened.

The process of getting a new build of the dependencies is broken to my opinion in that it required the workflows to run fist, have a bunch of them fail and then re-run them (using the retry failed ones Github button) to eventually have the CI pass.
It was exactly the same scenario for that previous PR AFAICT (libmicrohttpd).

Let me know if there is any information missing

@veloman-yunkan
Copy link
Collaborator

@rgaudin Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants