Replies: 7 comments 4 replies
-
|
We will try to merge this PR #2947 as we talked with @exezbcz that having a default white background would be required to roll new design partially, and @roiLeo introduced some good polishes there anyway! :) Then all white will come |
Beta Was this translation helpful? Give feedback.
-
|
Have we started working on this yet? would love to work on a page and revamp the design 😊 |
Beta Was this translation helpful? Give feedback.
-
|
Hi guys, after a little chit-chat with @yangwao. how do we continue with a redesign landing page without blocking the I'm thinking of using feature toggles on query parameters. So, the new design only can be viewed behind this URL: for example, on the landing page, modify this file https://github.com/kodadot/nft-gallery/blob/main/pages/index.vue#L1-L3 to something like this: <template>
<Landing v-if="newDesign" />
<LandingOld v-else />
</template>
<template>
<Footer v-if="newDesign" />
<FooterOld v-else />
</template>with this approach, we can safely merge the redesign components into the what do you guys think? |
Beta Was this translation helpful? Give feedback.
-
|
As discussed here #3895 We are running a few things for "upgrade"
Tough one! As discussed with @vikiival we would like to go with upgrading Vue3, which would mean a new branch, We will keep current flow merging things into stable The issue why we are doing this is that we have a ready design for landing page on the hand, for gallery and collection detail is in the works and the rest will definitely take a while, at least 3-6 weeks, plus some week two on top implementing stuff there. Thus moving fast, I would like to see gradually see this implemented as we still have a small audience (<10k users daily) than anticipated. As I believe UX would hugely benefit just from landing already. To address concerns #3895 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
thanks for the explanation
I just want to make sure this one. Does it mean we can merge redesigned components in the main branch without query parameters approach? if yes, we can close this PR #3895 and start redesign components gradually |
Beta Was this translation helpful? Give feedback.
-
|
Good Q! |
Beta Was this translation helpful? Give feedback.
-
|
Guys, what do you think about migration from |
Beta Was this translation helpful? Give feedback.
-
|
New components are based on oruga ui combined with histoire stories (#4167).
I don't really agree with that, since the code base was not made by one person, I find it easier to maintain than having handmade components. |
Beta Was this translation helpful? Give feedback.
-
|
Agree with @roiLeo, customizing Oruga is much easier than doing everything by hand,
|
Beta Was this translation helpful? Give feedback.
-
|
Added minting and section with other minor but important components we brought to light |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for all the fish |
Beta Was this translation helpful? Give feedback.
-
Hello, so we've kicked redesign as mentioned earlier on #3644
Yeah, it's getting there and will be really lovely refreshment for KodaDot
What do we plan to do in the first phase?
We decided to go with easy steps. Easy. 😅
We would like to redesign the whole K with an iterative rolling phase. That means we will try to get things out into production once it's finished on the design pipeline and iterate with various things in codebase as fast we can do, sounds courageous and brave 😅
Namely, we will go in a particular order
Batch of newly redesigned small components
What needs to be done, and how do we desire to proceed?
The thing is that lot of our components are copypasta, which is not good, and we should strive for highly functional and reusable components as we have more multichain stuff incoming.
As we feel special and love to break things often, we finally decided to migrate from Vue2.7.x to Vue3.
But, the thing is Buefy doesn't support Vue3 and Oruga will drop Vue2 support, soon
So after chatting with jtommy (author of buefy & oruga) we thought it would result in double migration. Well what we can do if we want to do revamp without doing an extensive code freeze, avoid backporting upgrades to new code, avoid any extra bugs &c and keep history (most precious).
Though once refactor for particular components will be done, we can start making upgrades components to Oruga.
As Oruga is a perfect CSS agnostic framework, we however continue with Bulma as the majority of our contributors understand it well which I bet help us do some small adjustments per se.
The good stuff is that I bet components we will support current needed stuff in Oruga in current state so no need worry about Oruga dropping Vue2, on the contrary, it will push us to migrate much sooner to Vue3.
The good news is that Nuxt3 is coming along as well.
With Nuxt3 and Vue3, we can cut build times with Vite and remove transpilling lot of packages.
Fast builds on Netlify, faster builds at your hands locally, faster hot-reload, development would feel much more smooth as back then again.
If I did not make any mistake in my "calculations", it should work very well, and our current contributors will be super happy for speedy updates on their local machines.
I hope the whole support of the code review guild will pinpoint during refactoring what we can do and how we can leverage the writing of components.
Steps to be done
Who is involved
Right now point of contact for design is @exezbcz, on Discord is Exez.
We decided that @preschian can help us with refactoring components as we noticed is really good on stuff with help of @Jarsen136, but I bet it's better to be done this by one person to not break some mental models
Design
Other CSS frameworks considered
Conclusion
I'm looking forward to the new revamp getting rolling and removing a lot of burdens we currently have 🥳
Feel free to drop any questions you might have. I fairly estimated that the whole process could be completed in under eight weeks, I bet we can do it under six weeks 🤞😁
Once done, it would be the biggest gift to the KodaDot community and Polkadot ecosystem out there.
Ref
Beta Was this translation helpful? Give feedback.
All reactions