Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add English-Korean translation glossary #16664

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Add English-Korean translation glossary #16664

merged 1 commit into from
Oct 24, 2019

Conversation

gochist
Copy link
Member

@gochist gochist commented Oct 2, 2019

Contents are migrated from 한글화팀 용어집

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2019
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 2, 2019
@gochist gochist force-pushed the glossary branch 2 times, most recently from 0a387f4 to 76e5e7c Compare October 3, 2019 06:53
@netlify
Copy link

netlify bot commented Oct 3, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit 0a387f4

https://deploy-preview-16664--k8s-dev-ko.netlify.com

@netlify
Copy link

netlify bot commented Oct 3, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit 76e5e7c

https://deploy-preview-16664--k8s-dev-ko.netlify.com

@ianychoi
Copy link
Contributor

ianychoi commented Oct 8, 2019

/assign ianychoi

@ianychoi
Copy link
Contributor

/lgtm

Minor note for future discussion: The term on the table should start with a capital letter, a small letter would be fine, or it would not matter at all?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2019
@gochist
Copy link
Member Author

gochist commented Oct 12, 2019

Minor note for future discussion: The term on the table should start with a capital letter, a small letter would be fine, or it would not matter at all?

@ianychoi We did not discuss about it ever. Following issue or PR will be welcomed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2019
@gochist gochist changed the base branch from dev-1.16-ko.2 to dev-1.16-ko.3 October 13, 2019 13:10
@seokho-son
Copy link
Member

@ianychoi Since this PR already got LGTM, I hope to approve this PR to follow dev-1.16-ko.3 schedule.
@gochist @ianychoi Thank you for your contribution and review !
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@seokho-son
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit c5e443e into kubernetes:dev-1.16-ko.3 Oct 24, 2019
gochist added a commit that referenced this pull request Oct 24, 2019
@ysyukr @gochist @seokho-son
Third Korean l10n work for release-1.16
6973002 
Update file outdated korean docs in dev-1.16-ko.3. (#16876)
Translate concepts/architecture/controller.md in Korean (#16889)
Change the full link in the document to an inline link. (#17059)
Add English-Korean translation glossary (#16664)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Oct 25, 2019
@gochist @ysyukr
@seokho-son @k8s-ci-robot
Third Korean l10n work for release-1.16 (#17168)
ff5d03a 
Update file outdated korean docs in dev-1.16-ko.3. (#16876)
Translate concepts/architecture/controller.md in Korean (#16889)
Change the full link in the document to an inline link. (#17059)
Add English-Korean translation glossary (#16664)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@seokho-son seokho-son Awaiting requested review from seokho-son

Assignees

@seokho-son seokho-son

@ianychoi ianychoi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gochist @ianychoi @seokho-son @k8s-ci-robot