Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change kontainer to container. #18131

Closed
wants to merge 1 commit into from
Closed

Change kontainer to container. #18131

wants to merge 1 commit into from

Conversation

irvifa
Copy link
Member

@irvifa irvifa commented Dec 14, 2019

This address our agreement on using container instead of kontainer.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 14, 2019
@irvifa
Copy link
Member Author

irvifa commented Dec 14, 2019

/cc @phanama
/cc @girikuncoro
/cc @danninov

@irvifa
Copy link
Member Author

irvifa commented Dec 14, 2019

/assign

@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 14, 2019
@irvifa
Copy link
Member Author

irvifa commented Dec 14, 2019

Address #15341

@irvifa
Copy link
Member Author

irvifa commented Dec 14, 2019

/uncc @davidopp

@k8s-ci-robot k8s-ci-robot removed the request for review from davidopp December 14, 2019 17:47
danninov
danninov reviewed Dec 15, 2019
View reviewed changes
content/id/docs/concepts/containers/container-environment-variables.md
seperti halnya variabel *environment* yang ditentukan secara statis di dalam *image* Docker.

### Informasi tentang Kluster

Daftar semua *Service* yang dijalankan ketika suatu Kontainer dibuat, tersedia di dalam Kontainer tersebut sebagai variabel *environment*.
Daftar semua *Service* yang dijalankan ketika suatu Container dibuat, tersedia di dalam Container tersebut sebagai variabel *environment*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to standardize whether first letter ini container word need to capitalize or not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@girikuncoro what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @phanama as well

danninov
danninov suggested changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@danninov danninov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some issue that need to addressed:

  1. Delete non-ID language that included in this PR
  2. Standardize whether the word container need to capitalize in the first letter or not
  3. Standardize translation of containerization to be di-container-isasi or dicontainer-isasi or other translation

content/id/docs/concepts/containers/container-lifecycle-hooks.md
content_template: templates/concept
weight: 30
---

{{% capture overview %}}

Laman ini menjelaskan bagaimana semua Kontainer yang diatur kubelet menggunakan *framework lifecycle hook*
Laman ini menjelaskan bagaimana semua Container yang diatur kubelet menggunakan *framework lifecycle hook*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to standardize whether first letter ini container word need to capitalize or not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @phanama @girikuncoro what do you think?

content/id/docs/tutorials/kubernetes-basics/_index.html
<li>Melakukan <i>scale</i> <i>deployment</i></li>
<li>Meng-update aplikasi yang sudah dikontainerisasi dengan menggunakan versi aplikasi terbaru</li>
<li>Men-debug aplikasi yang sudah dikontainerisasi</li>
<li>Meng-update aplikasi yang sudah di-container-isasi dengan menggunakan versi aplikasi terbaru</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many containerization translation that need to standardize whether to be di-container-isasi or dicontainer-isasi or even other translation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@girikuncoro @phanama any idea on this? cc @wahyuoi

Copy link
Contributor

@wahyuoi wahyuoi Dec 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kbbi.kemdikbud.go.id/entri/kontainerisasi

i think, we can use kontainerisasi

nvm, i didn't get the context before gave a comment. already got the context lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wahyuoi nice find! kontainerisasi it is then

content/no/_index.html Outdated Show resolved Hide resolved
content/no/docs/reference/glossary/container.md Outdated Show resolved Hide resolved
content/id/docs/tutorials/hello-minikube.md
Sebuah Kubernetes [*Pod*](/docs/concepts/workloads/pods/pod/) adalah kumpulan dari satu atau banyak Kontainer,
saling terhubung untuk kebutuhan administrasi dan jaringan. Pod dalam tutorial ini hanya punya satu Kontainer. Sebuah Kubernetes
Sebuah Kubernetes [*Pod*](/docs/concepts/workloads/pods/pod/) adalah kumpulan dari satu atau banyak Container,
saling terhubung untuk kebutuhan administrasi dan jaringan. Pod dalam tutorial ini hanya punya satu Container. Sebuah Kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to addresses whether the first letter need to capitalize or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the correct one is Container with capital C, because Container is API resource object in Kubernetes

@irvifa @danninov

@irvifa irvifa force-pushed the change-kontainer-to-container branch from de7a4a2 to 057806e Compare December 16, 2019 13:09
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2019
@irvifa irvifa force-pushed the change-kontainer-to-container branch 2 times, most recently from a46213b to 68e3351 Compare December 16, 2019 13:11
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign irvifa
You can assign the PR to them by writing /assign @irvifa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@irvifa irvifa force-pushed the change-kontainer-to-container branch from 68e3351 to 1a00ad1 Compare December 16, 2019 13:33
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2019
@irvifa
Copy link
Member Author

irvifa commented Dec 17, 2019

Closed in favor of #18177
/close

@k8s-ci-robot
Copy link
Contributor

@irvifa: Closed this PR.

In response to this:

Closed in favor of #18177
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irvifa irvifa deleted the change-kontainer-to-container branch December 17, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wahyuoi wahyuoi wahyuoi left review comments

@danninov danninov danninov requested changes

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

@phanama phanama Awaiting requested review from phanama

Assignees

@irvifa irvifa

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@irvifa @k8s-ci-robot @wahyuoi @girikuncoro @danninov