Camera crash ubuntu 22 gcc 9 5 #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
feature/camera-crash-ubuntu-22-gcc-9-5
branch
from
4189553
to
5a0eec8
Compare
On gcc 9.5 this variable was uninitialized and caused a buffer overflow crash.
patkenneally
force-pushed
the
feature/camera-crash-ubuntu-22-gcc-9-5
branch
from
5a0eec8
to
abe6961
Compare
thibaudteil
reviewed
Sep 7, 2023
Comment on lines
-39
to
-69
| this->pointImageOut = NULL; | ||
|
|
||
| /*! Default values for the camera. */ | ||
| this->cameraID = 1; | ||
| this->resolution[0] = 512; | ||
| this->resolution[1] = 512; | ||
| this->renderRate = (uint64_t) (60*1E9); | ||
| v3SetZero(this->cameraPos_B); | ||
| v3SetZero(this->sigma_CB); | ||
| this->cameraIsOn = 0; | ||
| this->filename = ""; | ||
| this->fieldOfView = 0.7; | ||
| strcpy(this->skyBox, "black"); | ||
| this->saveImages = 0; | ||
| this->saveDir = ""; | ||
| this->postProcessingOn = 0; | ||
| this->ppAperture = 0; | ||
| this->ppFocalLength = 0; | ||
| this->ppFocusDistance = 0; | ||
| this->ppMaxBlurSize = 0; | ||
|
|
||
| /*! Default values for the perturbations. */ | ||
| this->gaussian = 0; | ||
| this->darkCurrent = 0; | ||
| this->saltPepper = 0; | ||
| this->cosmicRays = 0; | ||
| this->blurParam = 0; | ||
| this->hsv = std::vector<double>{0., 0., 0.}; | ||
| this->bgrPercent = std::vector<int>{0, 0, 0}; | ||
|
|
||
| return; |
thibaudteil
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verification
Documentation
Future work