Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera crash ubuntu 22 gcc 9 5 #137

Closed
wants to merge 19 commits into from
Closed

Camera crash ubuntu 22 gcc 9 5 #137

wants to merge 19 commits into from

Commits on Sep 5, 2023

  1. Default initialize parentName 

    On gcc 9.5 this variable was uninitialized and caused a buffer overflow
crash.
    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    4ec9a62 View commit details
    Browse the repository at this point in the history

  2. Default initialize all variables

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    bdb16b0 View commit details
    Browse the repository at this point in the history

  3. Change hsv and bgr from Vector to Eigen::Vector3d

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    bf4dc38 View commit details
    Browse the repository at this point in the history

  4. Set empty destructor as defaulted

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    7df7f6b View commit details
    Browse the repository at this point in the history

  5. Pass by image by reference

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    825a6db View commit details
    Browse the repository at this point in the history

  6. Explicitly override Update and Reset methods

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3c47293 View commit details
    Browse the repository at this point in the history

  7. Declare each variable on a new line

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1aff4fd View commit details
    Browse the repository at this point in the history

  8. Remove redundant return statements

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a684415 View commit details
    Browse the repository at this point in the history

  9. Clean up code formatting

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3412eae View commit details
    Browse the repository at this point in the history

  10. Use nullptr instead of NULL

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    71039f9 View commit details
    Browse the repository at this point in the history

  11. Rename class CurrentSimNanos shadowing the Update parameter

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f75e3bb View commit details
    Browse the repository at this point in the history

  12. Refactor CurrentSimNanos to currentSimNanos

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    bc9da2e View commit details
    Browse the repository at this point in the history

  13. Refactor method names to be camel case

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    27f4371 View commit details
    Browse the repository at this point in the history

  14. Use explicit namespace cv for opencv function

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    87c3c34 View commit details
    Browse the repository at this point in the history

  15. Remove redundant method parameters

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    958fd9c View commit details
    Browse the repository at this point in the history

  16. Move test point values out of global scope

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    d3e15c7 View commit details
    Browse the repository at this point in the history

  17. Rename problematic variable shadowing

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f12fbaa View commit details
    Browse the repository at this point in the history

  18. Remove duplicate gauss string

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    33333eb View commit details
    Browse the repository at this point in the history

  19. Formating changes

    @patkenneally
    patkenneally committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    abe6961 View commit details
    Browse the repository at this point in the history