Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions filter menu collides with transaction table #2000

Closed
neb-b opened this issue Oct 4, 2018 · 8 comments
Closed

Transactions filter menu collides with transaction table #2000

neb-b opened this issue Oct 4, 2018 · 8 comments

Comments

@neb-b
Copy link

neb-b commented Oct 4, 2018

The Issue

Transactions filter menu collides with transaction table on small screens. This must have happened after #1985 was merged.

Steps to Reproduce

  1. View transactions page
  2. Shrink screen until the filter menu overlaps with the table

screen shot 2018-10-03 at 10 41 18 pm

Suggested Solutions

It currently uses position: absolute to achieve the positioning. Ideally the filter menu should just appear first in the dom so we don't need to hoist it up.

It should probably be in line with the title, just moved over to the right side.

@estevanjantsk
Copy link

captura de tela 2018-10-04 as 00 22 43

@seanyesmunt something like that? Thanks!

@neb-b
Copy link
Author

neb-b commented Oct 4, 2018

Hey @estevanjantsk! I think it would be better if it was inline with the Transaction History title. I added some additional info to the issue description

@estevanjantsk
Copy link

nice! I'll try that one 👍

@neb-b
Copy link
Author

neb-b commented Oct 4, 2018

Awesome! Let me know if you have any more questions 🙂

@ykris45
Copy link
Contributor

ykris45 commented Oct 4, 2018

@seanyesmunt i tested it with position relative and the Transactions filter menu uncolides

neb-b pushed a commit that referenced this issue Oct 10, 2018
Fix Transaction menu colides [#2000]
@ykris45
Copy link
Contributor

ykris45 commented Oct 10, 2018

close close..hehehe @seanyesmunt

@neb-b
Copy link
Author

neb-b commented Oct 10, 2018

@estevanjantsk We found a fix for this issue but I still think the solution we discussed would be preferable. If you are still working on it feel free to submit a PR!

@neb-b
Copy link
Author

neb-b commented Oct 16, 2018

I'm going to close this for now

@neb-b neb-b closed this as completed Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants