Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _card.scss #1985

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Update _card.scss #1985

merged 2 commits into from
Oct 1, 2018

Conversation

ykris45
Copy link
Contributor

@ykris45 ykris45 commented Sep 25, 2018

Invites section doesn't expand past a certain height
https://media.discordapp.net/attachments/363087331475062785/493920826505035776/unknown.png?width=693&height=428
Displays correctly when position is set from relative to initial in the CSS.

@@ -4,7 +4,7 @@
border-radius: var(--card-radius);
user-select: text;
display: flex;
position: relative;
position: initial;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe if you just remove this line should also work?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be ideal if it works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanyesmunt yes it works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@lbry-bot lbry-bot assigned neb-b and unassigned neb-b Sep 26, 2018
@neb-b
Copy link

neb-b commented Sep 26, 2018

@ykris45 We use the .card class in a lot of places. Have you tested that this doesnt affect other parts of the app? I will give it a test in a little bit.

@ykris45
Copy link
Contributor Author

ykris45 commented Sep 26, 2018

@seanyesmunt i doesnt have a lot of referalls. and i will test it on locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants