Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Transaction menu colides [#2000] #2005

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Fix Transaction menu colides [#2000] #2005

merged 2 commits into from
Oct 10, 2018

Conversation

ykris45
Copy link
Contributor

@ykris45 ykris45 commented Oct 4, 2018

i tested on my local development
image
if the position unchecked on my inspect element i will looks like
image
as @seanyesmunt said on issues #2000 ..

@neb-b
Copy link

neb-b commented Oct 4, 2018

@ykris45 I belive this messes with the invite table. Isn't that why you removed it originally?

@ykris45
Copy link
Contributor Author

ykris45 commented Oct 4, 2018

@seanyesmunt on invite table it use same element with transaction table, i added position: relative; to this element.

@neb-b
Copy link

neb-b commented Oct 4, 2018

Based on #1985 this will break the invite table. I think a better fix is described in #2000

@ykris45
Copy link
Contributor Author

ykris45 commented Oct 4, 2018

@seanyesmunt
image i think it wouldnt break the invite table

@ykris45
Copy link
Contributor Author

ykris45 commented Oct 4, 2018

@ykris45
Copy link
Contributor Author

ykris45 commented Oct 8, 2018

image
@seanyesmunt it will show based on my screenshot

@ykris45 ykris45 changed the title added position relative Fix Transaction menu colides [#2000] Oct 8, 2018
@neb-b
Copy link

neb-b commented Oct 9, 2018

Hey @ykris45. I'll give this a test tomorrow with the new flex styles.

@neb-b neb-b force-pushed the patch-2 branch 3 times, most recently from 7c5d525 to d64b028 Compare October 9, 2018 20:35
@neb-b neb-b merged commit 3523630 into lbryio:master Oct 10, 2018
@ykris45
Copy link
Contributor Author

ykris45 commented Oct 10, 2018

@seanyesmunt thanks brow

@tzarebczan tzarebczan added the hacktoberfest Welcome to Hacktoberfest label Oct 31, 2018
@ykris45 ykris45 deleted the patch-2 branch August 21, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Welcome to Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants