Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy initial commit, tags and categories #90

Merged
merged 3 commits into from
Oct 27, 2018

Conversation

khos2ow
Copy link
Contributor

@khos2ow khos2ow commented Oct 4, 2018

Taxonomy initial commit. It will show

  • tags
  • categories

on top of each post.

No Tags
image

Tags and Categories
image

It also shows designated title for taxonomy pages:

Tag
image

Category
image

Potentially we can show these taxonomies in /post list as well, which currently is not part of the PR, so any comments or suggestions are welcomed.

Fixes #57

@khos2ow
Copy link
Contributor Author

khos2ow commented Oct 4, 2018

@luizdepra I would suggest to proceed with #91 first so I can rebase this on top of that to be able to use the Netlify to validate the PR.

@khos2ow khos2ow force-pushed the taxonomy branch 2 times, most recently from 98efc48 to c299508 Compare October 4, 2018 16:33
@khos2ow
Copy link
Contributor Author

khos2ow commented Oct 4, 2018

@luizdepra this should be ready to go.

@luizdepra
Copy link
Owner

Hmm... I think the tags and categories are too much "featured". And we can hide these two infos when they are not present.

I just need some time to research and try other ways to show these infos.

@khos2ow
Copy link
Contributor Author

khos2ow commented Oct 9, 2018

I agree. I put them at the top because you mentioned it in #57

Add tags and categories into the post header. They can be placed near the post date or bellow, what looks better.

I personally like it better all the way after the post body at the bottom. Otherwise you're research is totally welcome.

@luizdepra
Copy link
Owner

Hey, how about if we change the date to use the same style of categories and tags? An calendar icon followed by the date. Something like this: https://themes.gohugo.io//theme/beautifulhugo/post/2017-03-20-photoswipe-gallery-sample/

Also, lets try with font-size: 1.4rem, same font as the text and reducing a bit the space between the lines. What do you think?
Ohh, and hide tags and categories when they are not defined.

@khos2ow
Copy link
Contributor Author

khos2ow commented Oct 13, 2018

I totally agree. I have the same overrided thing on my own website, as well as "Reading Time". I'll update the PR and we can see the difference in action to decide.

@luizdepra
Copy link
Owner

Reading time is a nice feature to have too.

@khos2ow khos2ow mentioned this pull request Oct 14, 2018
@khos2ow
Copy link
Contributor Author

khos2ow commented Oct 17, 2018

@luizdepra I'm showing taxonomy both at the header and footer of the post for comparison. I personally am in favor of the footer. Whichever you decide I can follow up on it and fix the layout.

@khos2ow
Copy link
Contributor Author

khos2ow commented Oct 24, 2018

@luizdepra ping.

@luizdepra
Copy link
Owner

luizdepra commented Oct 25, 2018

I've tested and changed it a bit.
Well, I thinks is simpler if I accept your PR and make the changes later. I will do it this weekend.

@khos2ow
Copy link
Contributor Author

khos2ow commented Oct 25, 2018

I enabled "allow edits from the maintainers", you should have access to directly work on this PR rather than merge it and fix it later.

@luizdepra
Copy link
Owner

Ok. Done.
I changed the icons to black, and fixed some SCSS and HTML code.

preview_taxonomy

@luizdepra luizdepra merged commit fd3ec89 into luizdepra:master Oct 27, 2018
@khos2ow
Copy link
Contributor Author

khos2ow commented Oct 27, 2018

Looks nice, thanks!

@khos2ow khos2ow deleted the taxonomy branch October 27, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants