-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taxonomy initial commit, tags and categories #90
Conversation
@luizdepra I would suggest to proceed with #91 first so I can rebase this on top of that to be able to use the Netlify to validate the PR. |
98efc48
to
c299508
Compare
@luizdepra this should be ready to go. |
Hmm... I think the tags and categories are too much "featured". And we can hide these two infos when they are not present. I just need some time to research and try other ways to show these infos. |
I agree. I put them at the top because you mentioned it in #57
I personally like it better all the way after the post body at the bottom. Otherwise you're research is totally welcome. |
Hey, how about if we change the date to use the same style of categories and tags? An calendar icon followed by the date. Something like this: https://themes.gohugo.io//theme/beautifulhugo/post/2017-03-20-photoswipe-gallery-sample/ Also, lets try with |
I totally agree. I have the same overrided thing on my own website, as well as "Reading Time". I'll update the PR and we can see the difference in action to decide. |
Reading time is a nice feature to have too. |
@luizdepra I'm showing taxonomy both at the header and footer of the post for comparison. I personally am in favor of the footer. Whichever you decide I can follow up on it and fix the layout. |
@luizdepra ping. |
I've tested and changed it a bit. |
I enabled "allow edits from the maintainers", you should have access to directly work on this PR rather than merge it and fix it later. |
Looks nice, thanks! |
Taxonomy initial commit. It will show
on top of each post.
No Tags
Tags and Categories
It also shows designated title for taxonomy pages:
Tag
Category
Potentially we can show these taxonomies in
/post
list as well, which currently is not part of the PR, so any comments or suggestions are welcomed.Fixes #57