Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Makefile and netlify deployment #91

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

khos2ow
Copy link
Contributor

@khos2ow khos2ow commented Oct 4, 2018

This PR enhances "deploy preview" on Netlify and Makefile targets.

Fixes #79

@khos2ow khos2ow changed the title WIP: Enhance Makefile and netlify deployment Enhance Makefile and netlify deployment Oct 4, 2018
Makefile Outdated
@@ -1,17 +1,18 @@
.PHONY: release build demo clean
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add prepare here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, good catch!

command = "make prepare && hugo --source demo"

[context.deploy-preview]
command = "make prepare && hugo --source demo --buildFuture --buildDrafts --baseURL $DEPLOY_PRIME_URL"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the HUGO_VERSION in this file too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@luizdepra luizdepra merged commit dcefc20 into luizdepra:master Oct 4, 2018
@khos2ow khos2ow deleted the netlify branch October 4, 2018 16:23
@luizdepra
Copy link
Owner

Thank you. I had to add some extra configuration into netlify.toml but everything is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants