Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products compare GraphQL schema #287

Closed
wants to merge 1 commit into from

Conversation

lenaorobei
Copy link
Contributor

Goal

Implement products compare GraphQL functionality.

Solution

Proposed by @kisroman schema and interfaces in following PRs:

Requested Reviewers

@paliarush
@akaplya

@kisroman
Copy link

kisroman commented Sep 24, 2019

  1. First I added new field hashed_id for every compare list to give ability get data by field hashed_id. This field is generating like quote id masked.
  2. I added one query compareProductsList - query to get compare list by hashed_id.
  3. Three mutation ware added: addProductToCompareList, removeProductFromCompareList, createCompareList.
    First createCompareList needed to be used to get hashed_id for compare list. It returns CreateCompareListOutput with hashed_id .
    addProductToCompareList is used with hashed_id and addProductToCompareListInput . addProductToCompareListInput contains ids - product ids to add to compare list.
    removeProductFromCompareList is used with hashed_id and removeProductFromCompareListInput. removeProductFromCompareListInput contains ids - product ids to remove from compare list.

@lenaorobei lenaorobei closed this Nov 6, 2019
@sivaschenko
Copy link
Member

@lenaorobei @kisroman @akaplya @paliarush was this proposition reviewed? What is the decision?

@lenaorobei
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants