Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

GraphQl-200: Product Compare #338

Merged
merged 2 commits into from
Dec 18, 2019
Merged

GraphQl-200: Product Compare #338

merged 2 commits into from
Dec 18, 2019

Conversation

kisroman
Copy link
Contributor

@kisroman kisroman commented Feb 1, 2019

Fixed Issues (if relevant)

  1. Product Compare #200

@naydav
Copy link
Contributor

naydav commented Feb 14, 2019

@kisroman
Please, looks on failed travis tests
Thanks

@kisroman
Copy link
Contributor Author

@naydav working on this.

@naydav
Copy link
Contributor

naydav commented Feb 21, 2019

Hi @kisroman,
Problem with builds is related to mistake in scheme declaration

@resolver (class: "Magento\\ProductCompareGraphQl\\Model\\Resolver\\addProductToCompareList")

Pay attention on class name.
Thanks

@naydav naydav mentioned this pull request Feb 21, 2019
Closed
4 tasks
@naydav naydav changed the title 200: Product Compare GraphQl-200: Product Compare May 2, 2019
@naydav naydav removed the in-progress label May 2, 2019
@naydav
Copy link
Contributor

naydav commented May 2, 2019

Hello @kisroman,,
We are going to include wishlist functionality in 2.3.3 release.
Could you merge last mainline and verify that code is actual
Thanks

@naydav
Copy link
Contributor

naydav commented Jun 21, 2019

@kisroman
Need to split this PR into two, core part and graphql part.
Please, let me know are you going to continue with this ticket?
Thanks

@kisroman kisroman mentioned this pull request Jul 15, 2019
Closed
@kisroman
Copy link
Contributor Author

magento/magento2#23704

@lenaorobei lenaorobei mentioned this pull request Sep 23, 2019
Closed
@lenaorobei lenaorobei changed the base branch from 2.3-develop to 2.3-develop-final December 18, 2019 21:18
@naydav naydav closed this Dec 18, 2019
@okorshenko okorshenko reopened this Dec 18, 2019
@okorshenko okorshenko merged commit 904e711 into magento:2.3-develop-final Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buskamuza buskamuza Awaiting requested review from buskamuza

@paliarush paliarush Awaiting requested review from paliarush

Assignees
No one assigned
Labels
Award: complex Award: special achievement on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kisroman @naydav @okorshenko @lenaorobei