-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphQl-200: Product Compare #23704
graphQl-200: Product Compare #23704
Conversation
Hi @kisroman. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento run all tests |
Hi @josefbehr, thank you for the review.
|
@TomashKhamlai unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
@kisroman thank you for all the efforts you put into these 2 PRs. Please understand that introducing new interfaces and schema changes require transparent approval flow by architecture team and must be publicly highlighted. Next steps that we are going to perform in order to process your PRs:
Once proposed schema will cover all use cases, we will be able to move forward. Sorry for such delay and hope for your understanding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kisroman , can you please add the description of changes introduced in the pull request and testing instructions. If approved it will also require the test coverage
Pull Request state was updated. Re-review required.
Hi @kisroman, thank you for your contribution! |
magento/graphql-ce#338