Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue #11354 Merged CSS file name generation #15144

Merged
merged 9 commits into from
May 15, 2018
Merged

Fixed Issue #11354 Merged CSS file name generation #15144

merged 9 commits into from
May 15, 2018

Conversation

sashas777
Copy link
Contributor

@sashas777 sashas777 commented May 10, 2018 •
edited
Loading

Fixed Issue #11354 Merged CSS file name generation

Description

When "Sign Static Files" option enabled at the Stores->Configuration->Advanced->Developer->Static Files Settings minified and merged CSS file md5 hash will be based on deployed version number.

This allows CSS code to be updated after each deploy at browser automatically. Previously you have to do CTRL+F5 after deploy to see CSS changes.

Fixed Issues (if relevant)

  1. Merged CSS file name generation #11354 : Merged CSS file name generation

Manual testing scenarios

  1. Stores->Configuration->Advanced->Developer set CSS Settings Merge and Minify CSS Files to YES
  2. Stores->Configuration->Advanced->Developer set JavaScript Settings Merge and Minify JavaScript Files to YES
  3. Stores->Configuration->Advanced->Developer->Static Files Settings set Sign Static Files tp YES
  4. Delete static content & deploy the static content again
  5. Remember the CSS filename
  6. Delete static content & deploy the static content again
  7. Compare to CSS file name to the file name ftop step 5. They should be different because the version of deployed files changed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 10, 2018
@magento-engcom-team
Copy link
Contributor

@sashas777 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sashas777 sashas777 assigned sashas777 and unassigned VladimirZaets May 10, 2018
@sidolov sidolov self-assigned this May 11, 2018
@DanielRuf DanielRuf self-requested a review May 11, 2018 21:42
@magento-engcom-team magento-engcom-team mentioned this pull request May 15, 2018
Closed
magento-team pushed a commit that referenced this pull request May 15, 2018
@VladimirZaets
ENGCOM-1520: Fixed Issue #11354 Merged CSS file name generation #15144
c70b7f7
@magento-engcom-team magento-engcom-team merged commit c4ba3ff into magento:2.2-develop May 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sashas777. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@sashas777 sashas777 mentioned this pull request Jun 27, 2018
Closed
4 tasks
@mageprince mageprince mentioned this pull request Jul 9, 2018
Merged
4 tasks
@ihor-sviziev ihor-sviziev mentioned this pull request Jul 19, 2018
Merged
4 tasks
magento-engcom-team added a commit that referenced this pull request Jul 23, 2018
@magento-engcom-team
ENGCOM-2416: Revert changing file permissions in #15144 #16937
e187f24 
 - Merge Pull Request #16937 from ihor-sviziev/magento2:fix-permissions-on-php-files
 - Merged commits:
   1. 65072e2
magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2018
ENGCOM-2416: Revert changing file permissions in #15144 #16937
323af80
magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2018
🔃 [EngCom] Public Pull Requests - 2.2-develop
95d2969 
Accepted Public Pull Requests:
 - #17002: [Backport] Remove unused comments from _initDiscount() function (by @mageprince)
 - #16980: Fixed a couple of spelling mistakes (by @mage2pratik)
 - #16977: Removed double occurrences from Magento modules (by @mage2pratik)
 - #16978: Wrong namespace defined in compare.phtml (by @ronak2ram)
 - #16928: Reduce lengthy code of LoginPost (by @GlennCheng)
 - #16937: Revert changing file permissions in #15144 (by @ihor-sviziev)
 - #16924: Replacing Usage of Deprecated Methods for Message Manager. (by @tiagosampaio)
 - #16889: Microrefactoring in product gallery block helper (by @likemusic)
 - #16890: hide cookie notice instead of reloading site (by @torhoehn)
 - #16903: Fixes white color coding standard. (by @chirag-wagento)
 - #16899: Fixing annotations for some methods. (by @tiagosampaio)
 - #16880: Array short syntax (by @lfluvisotto)
 - #16891: Remove commented code (by @mage2pratik)
 - #16882: Remove duplicated string. (by @likemusic)
 - #16851: Remove direct use of object manager (by @AnshuMishra17)
 - #16840: Log when Magento is in maintenance mode (by @Ethan3600)
 - #16841: Clean code (by @GraysonChiang)
 - #16785: Avoid undefined index warning when using uppercase reserved word (by @FreekVandeursen)
 - #16707: Update regex in ControllerAclTest (by @aleron75)
 - #16579: removed _responsive.less import from gallery.less (by @Karlasa)
@chirag-wagento chirag-wagento mentioned this pull request Jul 25, 2018
Merged
4 tasks
chirag-wagento pushed a commit to chirag-wagento/magento2 that referenced this pull request Jul 25, 2018
@ihor-sviziev @chirag-wagento
Revert changing file permissions in magento#15144
b01bdbc
chirag-wagento added a commit to chirag-wagento/magento2 that referenced this pull request Jul 25, 2018
@chirag-wagento
Merge pull request #6 from chirag-wagento/2.3-develop-PR-port-16937
7fd0126 
[Forwardport] Revert changing file permissions in magento#15144
@chirag-wagento chirag-wagento mentioned this pull request Jul 25, 2018
Merged
4 tasks
chirag-wagento pushed a commit to chirag-wagento/magento2 that referenced this pull request Jul 25, 2018
@ihor-sviziev @chirag-wagento
Revert changing file permissions in magento#15144
df5234b
@chirag-wagento chirag-wagento mentioned this pull request Jul 25, 2018
Closed
4 tasks
chirag-wagento added a commit to chirag-wagento/magento2 that referenced this pull request Jul 25, 2018
@chirag-wagento
Merge pull request #7 from chirag-wagento/2.1-develop-PR-port-16937
0eac82d 
[Backport] Revert changing file permissions in magento#15144
@chirag-wagento chirag-wagento mentioned this pull request Jul 25, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees

@sashas777 sashas777

@sidolov sidolov

Labels
Award: bug fix Progress: accept Release Line: 2.2
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@sashas777 @magento-engcom-team @DanielRuf @VladimirZaets @sidolov