Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approval banner fix, and graphql dependabot update #832

Merged
merged 27 commits into from
Sep 27, 2023
Merged

approval banner fix, and graphql dependabot update #832

merged 27 commits into from
Sep 27, 2023

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Sep 26, 2023 •
edited
Loading

-Bump graphql from 16.6.0 to 16.8.1 by https://github.com/dependabot in #831
-only one option when defaulting to default value in #830
-update gray matter

b-pmcg and others added 23 commits July 25, 2023 10:37
@b-pmcg
0.11.5
6392c6f
@hernandoagf
Feat: poll review link & no delegate migration for shadow delegates (#…
42b4273 
…817)

* Add poll copy url to poll details page

* Remove migration banner for shadow delegates
@hernandoagf @adamgoth
Feat: AVCs page (#815)
6f54089 
* feat: Add functions and modules for AVCs page

* Add AVC UI components

* Fetch AVC delegate count and MKR delegated

* Add AVC list page

* Use delegate system stats for delegate pages

* Add new Endgame FAQ links

* Parse and limit length of AVC description

* Remove "View AVC details" button

* Add AVC link in mobile navigation menu

* Fix spec

---------

Co-authored-by: Adam Goth <[email protected]>
@adamgoth
Bump version
333a7c7
@adamgoth
Merge branch 'master' of https://github.com/makerdao/governance-porta…
4954dec 
…l-v2 into develop
@adamgoth
Disable AVC detail link on avatar
d614776
@adamgoth
Edit link titles
0291161
@adamgoth
Hide view button if no delegates for AVC exist
16311ef
@b-pmcg
make test amount a variable
e993a9d
@dependabot
Bump protobufjs from 6.11.3 to 6.11.4 (#819)
c48c2a8 
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.3 to 6.11.4.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/protobufjs/protobuf.js/commits)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @adobe/css-tools from 4.2.0 to 4.3.1 (#820)
01d6126 
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@inclinedmind
show all avcs button, match button styles
da4e3ea
@tyler17
Merge pull request #824 from makerdao/master
e96cecc 
master -> develop
@tyler17
Merge pull request #826 from makerdao/master
806bdb7 
Master -> dev
@tyler17
Merge pull request #823 from makerdao/show-all-avcs
dd1529b 
Show all avcs button
@tyler17
update vote proxy text and links
450e81f
@tyler17
remove available soon
ea0d6e0
@tyler17
Merge pull request #827 from makerdao/update-vote-proxy-guide
cf210bc 
Update vote proxy guide
@adamgoth
Bump version
f0c2171
@tyler17
only one option when defaulting to default value
02f7fde
@dependabot
Bump graphql from 16.6.0 to 16.8.1
4f29b23 
Bumps [graphql](https://github.com/graphql/graphql-js) from 16.6.0 to 16.8.1.
- [Release notes](https://github.com/graphql/graphql-js/releases)
- [Commits](graphql/graphql-js@v16.6.0...v16.8.1)

---
updated-dependencies:
- dependency-name: graphql
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@tyler17
Merge pull request #831 from makerdao/dependabot/npm_and_yarn/graphql…
a7bd6fc 
…-16.8.1

Bump graphql from 16.6.0 to 16.8.1
@tyler17
Merge pull request #830 from makerdao/poll-banner-fix
32c7559 
only one option when defaulting to default value
@vercel
Copy link

vercel bot commented Sep 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Sep 27, 2023 8:43pm

@what-the-diff
Copy link

what-the-diff bot commented Sep 26, 2023 •
edited
Loading

PR Summary

  • Optimization in PollWinningOptionBox.tsx
    The calculation of the leading option and its name, in a 'Poll Winning Option Box' feature, has been optimized. The code now checks if the default option is not selected, and only then does it display other leading options. This makes the functionality more efficient.

  • Added safety check in parsePollMetadata.ts
    A new option was integrated into parsing function of poll's metadata. Instead of attempting to parse and convert JavaScript, the program will now simply log a message and return a blank object or string. This reduces unnecessary workload and hence, improves performance.

  • Software Package and Dependency Updates
    The software has been updated to version '0.11.8'. Further, a key dependency - graphql has also been upgraded from '^16.2.0' to '^16.8.1', which likely includes recent security fixes, performance improvements and new features. It's part of keeping the software up-to-date with latest improvements in its dependencies.

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
graphql 16.6.0...16.8.1 None +0/-0 1.34 MB i1g

generatorpoint
generatorpoint approved these changes Sep 26, 2023
View reviewed changes
Copy link

@generatorpoint generatorpoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

adamgoth
adamgoth previously approved these changes Sep 27, 2023
View reviewed changes
@tyler17 tyler17 merged commit e53190b into master Sep 27, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-pmcg b-pmcg b-pmcg approved these changes

@hernandoagf hernandoagf hernandoagf approved these changes

@generatorpoint generatorpoint generatorpoint approved these changes

@adamgoth adamgoth adamgoth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tyler17 @adamgoth @b-pmcg @hernandoagf @generatorpoint @inclinedmind