Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Support filtering and searching for users to invite in DMs #3802

Merged
merged 5 commits into from
Jan 6, 2020

Conversation

turt2live
Copy link
Member

This is based off #3801 - use pull/3801/head...pull/3802/head to compare the diffs.

This might be easier to review commit-by-commit.

Fixes element-hq/element-web#11200

image

Fixes element-hq/element-web#11198

Note this doesn't implement the entire algorithm in 11198 because it feels too complicated at this stage. Instead, the idea is to review the suggestions closer to when the whole dialog is complete and fix them then: element-hq/element-web#11769

Algorithm for picking members is largely based on db5218e
@turt2live turt2live force-pushed the travis/ftue/user-lists/3-filtering branch from 3e254c7 to 8b4c1e3 Compare January 4, 2020 04:22
@turt2live turt2live requested a review from a team January 4, 2020 04:24
@jryans jryans requested review from jryans and removed request for a team January 6, 2020 17:28
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great! 😁 I'd like to know more about the entity encoding first.

src/components/views/dialogs/DMInviteDialog.js Outdated Show resolved Hide resolved
src/components/views/dialogs/DMInviteDialog.js Outdated Show resolved Hide resolved
src/components/views/dialogs/DMInviteDialog.js Outdated Show resolved Hide resolved
React will take care of this for us. It's harmful because simple characters get converted to something illegible.
@turt2live turt2live requested a review from jryans January 6, 2020 19:22
@turt2live turt2live merged commit b44e4ab into develop Jan 6, 2020
@turt2live turt2live deleted the travis/ftue/user-lists/3-filtering branch January 6, 2020 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesigned search results in suggestions/recent conversations in Invite/Create DM dialog
2 participants