Update bundle image #202
Merged
Update bundle image #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run 'VERSION=SOME_VERSION' prior to running the bundle-run or bundle-run-update targets to modify the installed or replaced bundle CSV
OPERATOR_NAMESPACE is widely used in other Medik8s operators
|
Skipping CI for Draft Pull Request. |
clobrano
approved these changes
May 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
tide is off for an unknown reason but all the tests are green so I am manually merging the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR
Introduce a new target,
bundle-run-update, for testing an operator upgrade.It could be used as well for downgrading or reinstalling the operator (instead of running the bundle-cleanup and then bundle-run).
Run 'VERSION=SOME_VERSION' prior to running the bundle-run or bundle-run-update targets to modify the installed or replaced bundle CSV.
The new target will be used for testing operator upgrades in OCP CI (e.g., NMO and FAR ).
Similar PR to NMO #120 and FAR #139.
Changes made
bundle-run-updatetargetBUNDLE_RUN_NAMESPACEtoOPERATOR_NAMESPACEin MakefileWhich issue(s) this PR fixes
ECOPROJECT-1082
Test plan
None