Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test NMO operator upgrade from v0.17.0 to latest #50559

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Apr 3, 2024

Perform an operator upgrade test from the last released version to the latest commit in main.
Upgrade an old operator to a new one on the same OCP cluster, see https://docs.ci.openshift.org/docs/how-tos/testing-operator-sdk-operators/#operator-upgrade-testing

@razo7
Copy link
Member Author

razo7 commented Apr 3, 2024

/pj-rehearse max

@openshift-ci openshift-ci bot requested review from mshitrit and slintes April 3, 2024 15:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
Copy link
Member

@slintes slintes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@razo7
Copy link
Member Author

razo7 commented Apr 8, 2024

It seems like the test was never tested...
/pj-rehearse pull-ci-medik8s-fence-agents-remediation-main-4.16-far-upgarde-latest

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7 razo7 changed the title Test upgrade FAR v0.3.0 from to latest Test NMO operator upgrade from v0.17.0 to latest Apr 8, 2024
@razo7
Copy link
Member Author

razo7 commented Apr 8, 2024

FAR doesn't have the bundle-run-update target, so switching the change and testing for NMO ATM

@razo7
Copy link
Member Author

razo7 commented Apr 8, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.16-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 8, 2024

/hold

Good input, I have followed your suggestions, applied them for NMO, and I will now add the upgrade utility in FAR

@razo7
Copy link
Member Author

razo7 commented Apr 8, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.16-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 8, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.16-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 8, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.16-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 8, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.16-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 9, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 9, 2024
Make OCP-e2e cluster test a three steps test- installing old version, update to latest, test e2e test
@razo7
Copy link
Member Author

razo7 commented Apr 9, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 9, 2024
Fetch old released version from Quay for the first installation
@razo7
Copy link
Member Author

razo7 commented Apr 9, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@razo7: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-medik8s-node-maintenance-operator-main-4.16-ci-bundle-my-bundle medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.16-images medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.16-openshift-e2e medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.16-test medik8s/node-maintenance-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

@razo7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/medik8s/fence-agents-remediation/main/4.16-far-upgarde-latest 1198655 link unknown /pj-rehearse pull-ci-medik8s-fence-agents-remediation-main-4.16-far-upgarde-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@razo7
Copy link
Member Author

razo7 commented Apr 14, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 14, 2024

/retest

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 14, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0051be4 into openshift:master Apr 15, 2024
21 checks passed
saifshaikh48 pushed a commit to saifshaikh48/release that referenced this pull request Apr 23, 2024
* Include NMO upgrade installation test in OCP-e2e cluster test

Make OCP-e2e cluster test a three steps test- installing old version, update to latest, test e2e test

* Use quay released version

Fetch old released version from Quay for the first installation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants