Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundle image #139

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Update bundle image #139

merged 2 commits into from
Apr 25, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Apr 8, 2024

Why we need this PR

Introduce a new target, bundle-run-update, for testing an operator upgrade.
It could be used as well for downgrading or reinstalling the operator (instead of running the bundle-cleanup and then bundle-run).

Run 'VERSION=SOME_VERSION' prior to running the bundle-run or bundle-run-update targets to modify the installed or replaced bundle CSV.

The new target will be used for testing operator upgrades in OCP CI - openshift/release#50559

Changes made

  • Add bundle-run-update target
  • Change var name BUNDLE_RUN_NAMESPACE to OPERATOR_NAMESPACE in Makefile

Which issue(s) this PR fixes

ECOPROJECT-1082

Test plan

Similar to PR of NMO #120

Run 'VERSION=SOME_VERSION' prior to running the bundle-run or bundle-run-update targets to modify the installed or replaced bundle CSV
OPERATOR_NAMESPACE is widely used in other Medik8s operators
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@clobrano
Copy link
Contributor

clobrano commented Apr 9, 2024

Considering that it supposed to perform both upgrade and downgrade, would be bundle-run-replace be a clearer option?

@razo7
Copy link
Member Author

razo7 commented Apr 9, 2024

Considering that it supposed to perform both upgrade and downgrade, would be bundle-run-replace be a clearer option?

I don't have a strong preference here. bundle-run-update also seems fine as we update the CSV.

@razo7 razo7 marked this pull request as ready for review April 14, 2024 04:35
@openshift-ci openshift-ci bot requested review from beekhof and clobrano April 14, 2024 04:36
@razo7
Copy link
Member Author

razo7 commented Apr 14, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slintes
Copy link
Member

slintes commented Apr 22, 2024

/lgtm cancel

@slintes
Copy link
Member

slintes commented Apr 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 22, 2024
@slintes
Copy link
Member

slintes commented Apr 25, 2024

ping tide

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@razo7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.12-openshift-e2e 31ace84 link unknown /test 4.12-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@slintes
Copy link
Member

slintes commented Apr 25, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 13beff0 into medik8s:main Apr 25, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants