Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to change font #17987

Closed
withinboredom opened this issue Oct 2, 2024 · 1 comment · Fixed by #17989
Closed

Unable to change font #17987

withinboredom opened this issue Oct 2, 2024 · 1 comment · Fixed by #17989
Assignees
@DHowett
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@withinboredom
Copy link

Windows Terminal version

1.22.2702.0

Windows build number

10.0.22631.0

Other Software

N/A

Steps to reproduce

Go to settings, appearance, change font.

Expected Behavior

The font to change

Actual Behavior

Settings.2024-10-02.18-40-49.mp4

The font doesn't save.
@withinboredom withinboredom added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 2, 2024
@DHowett
Copy link
Member

DHowett commented Oct 2, 2024

Thanks! This regressed in #17961

@DHowett DHowett mentioned this issue Oct 2, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 2, 2024
@DHowett DHowett added Product-Terminal The new Windows Terminal. Area-Settings UI Anything specific to the SUI and removed Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting In-PR This issue has a related PR labels Oct 2, 2024
@DHowett DHowett self-assigned this Oct 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Oct 2, 2024
@DHowett DHowett added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting and removed Product-Terminal The new Windows Terminal. Needs-Tag-Fix Doesn't match tag requirements Area-Settings UI Anything specific to the SUI labels Oct 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Oct 2, 2024
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. In-PR This issue has a related PR Product-Terminal The new Windows Terminal. Priority-1 A description (P1) Area-Settings UI Anything specific to the SUI labels Oct 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 2, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 2, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Oct 2, 2024
DHowett added a commit that referenced this issue Oct 3, 2024
@DHowett
Revert "Stop updating AutoSuggestBox on selection" (#17989)
b715008 
Reverts #17961
Closes #17987 
Reopens #17916
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Oct 3, 2024
@lhecker lhecker mentioned this issue Oct 9, 2024
Closed
DHowett added a commit that referenced this issue Oct 9, 2024
@DHowett
Revert "Stop updating AutoSuggestBox on selection" (#17989)
f16f513 
Reverts #17961
Closes #17987
Reopens #17916

(cherry picked from commit b715008)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTiWbM
Service-Version: 1.21
DHowett added a commit that referenced this issue Oct 9, 2024
@DHowett
Revert "Stop updating AutoSuggestBox on selection" (#17989)
a0987c2 
Reverts #17961
Closes #17987
Reopens #17916

(cherry picked from commit b715008)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTiWbQ
Service-Version: 1.22
@DHowett DHowett mentioned this issue Oct 10, 2024
Closed
This was referenced Oct 11, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

Successfully merging a pull request may close this issue.

Revert "Stop updating AutoSuggestBox on selection" microsoft/terminal
3 participants
@DHowett @withinboredom @carlos-zamora