Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Stop updating AutoSuggestBox on selection" #17989

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Revert "Stop updating AutoSuggestBox on selection" #17989

merged 1 commit into from
Oct 3, 2024

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Oct 2, 2024 •
edited
Loading

Reverts #17961

Closes #17987

Reopens #17916

@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Oct 2, 2024
carlos-zamora
carlos-zamora approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh.

Reopens #17916 too

@microsoft-github-policy-service microsoft-github-policy-service bot added Area-Settings UI Anything specific to the SUI Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Oct 2, 2024
@DHowett
Copy link
Member Author

DHowett commented Oct 2, 2024

Thanks for the reopen notes, Carlos!

@DHowett DHowett enabled auto-merge (squash) October 2, 2024 22:41
@DHowett DHowett merged commit b715008 into main Oct 3, 2024
18 of 20 checks passed
@DHowett DHowett deleted the revert-17961-dev/lhecker/17916-rm-rf-winui branch October 3, 2024 15:24
@lhecker lhecker mentioned this pull request Oct 9, 2024
Closed
DHowett added a commit that referenced this pull request Oct 9, 2024
@DHowett
Revert "Stop updating AutoSuggestBox on selection" (#17989)
f16f513 
Reverts #17961
Closes #17987
Reopens #17916

(cherry picked from commit b715008)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTiWbM
Service-Version: 1.21
DHowett added a commit that referenced this pull request Oct 9, 2024
@DHowett
Revert "Stop updating AutoSuggestBox on selection" (#17989)
a0987c2 
Reverts #17961
Closes #17987
Reopens #17916

(cherry picked from commit b715008)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTiWbQ
Service-Version: 1.22
@lhecker lhecker mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
1.21 Servicing Pipeline
Status: Cherry Picked
1.22 Servicing Pipeline
Status: Cherry Picked
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to change font
3 participants
@DHowett @lhecker @carlos-zamora