Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default for autoMarkPrompts to true #17761

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Set the default for autoMarkPrompts to true #17761

merged 1 commit into from
Aug 21, 2024

Commits on Aug 20, 2024

  1. Set the default for autoMarkPrompts to true 

    As we discussed in bug bash.

There's really no downside to us enabling it by default (and leaving showMarksOnScrollbar: false).
It'll mark lines as "prompts" when the user hits enter. This will have a couple good side effects:
* When folks have right-aligned prompts (like, from oh-my-posh), the `enter`
  will terminate where shell integration thinks the command is, so that the
  right-prompt doesn't end up in the commandline history
* the scrollToMark actions will Just Work without any other shell integration

Closes #17632
    @zadjii-msft
    zadjii-msft committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    030f594 View commit details
    Browse the repository at this point in the history